Optimize PaintInvalidatorContext::mapLocalRectToVisualRectInBacking()

third_party/WebKit/Source/core/paint/PaintInvalidator.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaintInvalidator_h
 #define PaintInvalidator_h
 
 #include "platform/geometry/LayoutRect.h"
 #include "platform/graphics/paint/GeometryMapper.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
 class FrameView;
 class LayoutBoxModelObject;
 class LayoutObject;
 class PaintLayer;
 struct PaintPropertyTreeBuilderContext;
 
 struct PaintInvalidatorContext {
   PaintInvalidatorContext(
-      const PaintPropertyTreeBuilderContext& treeBuilderContext)
-      : treeBuilderContext(treeBuilderContext), parentContext(nullptr) {}
+      const PaintPropertyTreeBuilderContext& treeBuilderContext,
+      GeometryMapper& geometryMapper)
+      : treeBuilderContext(treeBuilderContext),
+        geometryMapper(geometryMapper),
+        parentContext(nullptr) {}
 
   PaintInvalidatorContext(
       const PaintPropertyTreeBuilderContext& treeBuilderContext,
       const PaintInvalidatorContext& parentContext)
       : treeBuilderContext(treeBuilderContext),
+        geometryMapper(parentContext.geometryMapper),
         parentContext(&parentContext),
         forcedSubtreeInvalidationFlags(
             parentContext.forcedSubtreeInvalidationFlags),
         paintInvalidationContainer(parentContext.paintInvalidationContainer),
         paintInvalidationContainerForStackedContents(
             parentContext.paintInvalidationContainerForStackedContents),
         paintingLayer(parentContext.paintingLayer) {}
 
-  // This method is temporary to adapt PaintInvalidatorContext and the legacy
-  // PaintInvalidationState for code shared by old code and new code.
+  // This method is virtual temporarily to adapt PaintInvalidatorContext and the
+  // legacy PaintInvalidationState for code shared by old code and new code.
   virtual void mapLocalRectToVisualRectInBacking(const LayoutObject&,
                                                  LayoutRect&) const;
 
   const PaintPropertyTreeBuilderContext& treeBuilderContext;
+  GeometryMapper& geometryMapper;
   const PaintInvalidatorContext* parentContext;
 
   enum ForcedSubtreeInvalidationFlag {
     ForcedSubtreeInvalidationChecking = 1 << 0,
     ForcedSubtreeInvalidationRectUpdate = 1 << 1,
     ForcedSubtreeFullInvalidation = 1 << 2,
     ForcedSubtreeFullInvalidationForStackedContents = 1 << 3,
     ForcedSubtreeSVGResourceChange = 1 << 4,
     // TODO(crbug.com/637313): This is temporary before we support filters in
     // paint property tree.
@@ skipping 28 matching lines @@
   // invalidation backing's coordinates. They are used to detect layoutObject
   // shifts that force a full invalidation and invalidation check in subtree.
   // The points do *not* account for composited scrolling. See
   // LayoutObject::adjustVisualRectForCompositedScrolling().
   LayoutPoint oldLocation;
   LayoutPoint newLocation;
 };
 
 class PaintInvalidator {
  public:
-  PaintInvalidator(GeometryMapper& geometryMapper)
-      : m_geometryMapper(geometryMapper) {}
-
   void invalidatePaintIfNeeded(FrameView&, PaintInvalidatorContext&);
   void invalidatePaintIfNeeded(const LayoutObject&, PaintInvalidatorContext&);
 
   // Process objects needing paint invalidation on the next frame.
   // See the definition of PaintInvalidationDelayedFull for more details.
   void processPendingDelayedPaintInvalidations();
 
  private:
   ALWAYS_INLINE LayoutRect
   computeVisualRectInBacking(const LayoutObject&,
                              const PaintInvalidatorContext&);
   ALWAYS_INLINE LayoutPoint
   computeLocationInBacking(const LayoutObject&, const PaintInvalidatorContext&);
   ALWAYS_INLINE void updatePaintingLayer(const LayoutObject&,
                                          PaintInvalidatorContext&);
   ALWAYS_INLINE void updatePaintInvalidationContainer(const LayoutObject&,
                                                       PaintInvalidatorContext&);
   ALWAYS_INLINE void updateVisualRect(const LayoutObject&,
                                       PaintInvalidatorContext&);
 
   Vector<const LayoutObject*> m_pendingDelayedPaintInvalidations;
-  GeometryMapper& m_geometryMapper;
 };
 
 }  // namespace blink
 
 #endif  // PaintInvalidator_h