Move spaces from before comments to within comments

Add comments


Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/6a7d6c385e7cfa2f86b832d0281bb217d86055fd

[Jacob, 2017-03-21 00:56:41]

jacobr@google.com changed reviewers:
+ sra@google.com

[Jacob, 2017-03-21 00:56:42]

Also automatically add a second comment so that 
multitest comment indentation can be preserved without
tweaking multitest syntax

[sra1, 2017-03-21 01:43:48]

// = missing //

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/23486_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/23486_test.dart:35: Expect.throws(() => new
D.name()); /// 02: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/bounds_check_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/bounds_check_test.dart:12:
checkIndexedAssignment(a, -1);  /// 06: runtime error
//

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/bounds_check_test.dart:14:
checkIndexedAssignment(a, 2);   /// 08: runtime error
//

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/int_index_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/int_index_test.dart:8: a[1.2] = 4; /// 02: runtime
error
//

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/label_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/label_test.dart:37: (() { break foo; })();  /// 07:
continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/minus_zero_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/minus_zero_test.dart:15: int i = MINUS_ZERO;  ///
01: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/minus_zero_test.dart:17: Expect.equals(3, i); ///
01: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/from_environm...
File tests/corelib/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/from_environm...
tests/corelib/from_environment_const_type_test.dart:11: bool   /// 01: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/from_environm...
File tests/corelib/from_environment_const_type_undefined_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/from_environm...
tests/corelib/from_environment_const_type_undefined_test.dart:10: bool   /// 01:
ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/int_parse_rad...
File tests/corelib/int_parse_radix_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/int_parse_rad...
tests/corelib/int_parse_radix_test.dart:67: testParse(pow(i, 64) - 1, digit *
64, i);  /// 02: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/int_parse_rad...
tests/corelib/int_parse_radix_test.dart:76:
Expect.equals(0x12345678123456781234567812345678,  /// 02: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/integer_to_st...
File tests/corelib/integer_to_string_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/integer_to_st...
tests/corelib/integer_to_string_test.dart:64: test(0xffffffffffffffff,
"18446744073709551615");   /// 01: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_retu...
File tests/corelib/iterable_return_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_retu...
tests/corelib/iterable_return_type_test.dart:66: testList(new Uint8List(1)..[0]
= 1);   /// 01: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_to_l...
File tests/corelib/iterable_to_list_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_to_l...
tests/corelib/iterable_to_list_test.dart:33: testIterable(new
Float32List.fromList([1.0, 2.0, 3.0]),  /// 01: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
File tests/corelib/num_sign_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
tests/corelib/num_sign_test.dart:63: 2.2250738585072014e-308,  // min normal
erk

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
tests/corelib/num_sign_test.dart:76: 1.7976931348623157e+308,  // max finite
double
erk

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/regexp/captur...
File tests/corelib/regexp/capture-3_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/regexp/captur...
tests/corelib/regexp/capture-3_test.dart:68: NoHang(new
RegExp(r"(((.*)*)*Ā)foo"));  // Body of loop filtered.
erk

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_operat...
File tests/corelib/symbol_operator_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_operat...
tests/corelib/symbol_operator_test.dart:31: testSymbolThrows(">>>");  /// 03: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_reserv...
File tests/corelib/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_reserv...
tests/corelib/symbol_reserved_word_test.dart:22: checkBadSymbol('void.foo');  
/// 06: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/uri_test.dart
File tests/corelib/uri_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/uri_test.dart...
tests/corelib/uri_test.dart:502: // and no colon before slash in path.
??

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/from_e...
File tests/corelib_strong/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/from_e...
tests/corelib_strong/from_environment_const_type_test.dart:11: bool   /// 01: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/from_e...
File tests/corelib_strong/from_environment_const_type_undefined_test.dart
(right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/from_e...
tests/corelib_strong/from_environment_const_type_undefined_test.dart:10: bool  
/// 01: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/int_pa...
File tests/corelib_strong/int_parse_radix_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/int_pa...
tests/corelib_strong/int_parse_radix_test.dart:67: testParse(pow(i, 64) - 1,
digit * 64, i);  /// 02: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/int_pa...
tests/corelib_strong/int_parse_radix_test.dart:76:
Expect.equals(0x12345678123456781234567812345678,  /// 02: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/intege...
File tests/corelib_strong/integer_to_string_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/intege...
tests/corelib_strong/integer_to_string_test.dart:64: test(0xffffffffffffffff,
"18446744073709551615");   /// 01: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/iterab...
File tests/corelib_strong/iterable_return_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/iterab...
tests/corelib_strong/iterable_return_type_test.dart:66: testList(new
Uint8List(1)..[0] = 1);   /// 01: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/num_si...
File tests/corelib_strong/num_sign_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/num_si...
tests/corelib_strong/num_sign_test.dart:63: 2.2250738585072014e-308,  // min
normal
??

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/num_si...
tests/corelib_strong/num_sign_test.dart:76: 1.7976931348623157e+308,  // max
finite double
??

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/regexp...
File tests/corelib_strong/regexp/capture-3_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/regexp...
tests/corelib_strong/regexp/capture-3_test.dart:68: NoHang(new
RegExp(r"(((.*)*)*Ā)foo"));  // Body of loop filtered.
??

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/string...
File tests/corelib_strong/string_case_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/string...
tests/corelib_strong/string_case_test.dart:35: Expect.equals("\xff",
"\xff".toUpperCase().toLowerCase());  /// 03: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
File tests/corelib_strong/symbol_operator_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
tests/corelib_strong/symbol_operator_test.dart:31: testSymbolThrows(">>>");  ///
03: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
tests/corelib_strong/symbol_operator_test.dart:31: testSymbolThrows(">>>");  ///
03: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
File tests/corelib_strong/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
tests/corelib_strong/symbol_reserved_word_test.dart:28: x = const
Symbol('assert');   /// 10: compile-time error
//

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/uri_te...
File tests/corelib_strong/uri_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/uri_te...
tests/corelib_strong/uri_test.dart:217: // and no colon before slash in path.
??

https://codereview.chromium.org/2763823002/diff/1/tests/isolate/message3_test...
File tests/isolate/message3_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/isolate/message3_test...
tests/isolate/message3_test.dart:175: ping.send(byteBuffer);  /// byteBuffer: ok
//

https://codereview.chromium.org/2763823002/diff/1/tests/isolate/remote_unitte...
File tests/isolate/remote_unittest_helper.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/isolate/remote_unitte...
tests/isolate/remote_unittest_helper.dart:20: * //       the usual test.
??

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_fac...
File tests/language/abstract_factory_constructor_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_fac...
tests/language/abstract_factory_constructor_test.dart:28: new A2.make(); //     
     /// 00: continued
revert

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_run...
File tests/language/abstract_runtime_error_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_run...
tests/language/abstract_runtime_error_test.dart:40: "expected
AbstractClassInstantiationError");  /// 01: continued
??

https://codereview.chromium.org/2763823002/diff/1/tests/language/arg_param_tr...
File tests/language/arg_param_trailing_comma_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/arg_param_tr...
tests/language/arg_param_trailing_comma_test.dart:43: void
afterFunsigDefaultValueY([void f() = topy,]) {}  /// none: continued
//

https://codereview.chromium.org/2763823002/diff/1/tests/language/assert_initi...
File tests/language/assert_initializer_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/assert_initi...
tests/language/assert_initializer_test.dart:39: const c = const
AssertArgument.constFirstSuper(false, 0, 1);  /// 05: compile-time error
//

https://codereview.chromium.org/2763823002/diff/1/tests/language/assign_top_m...
File tests/language/assign_top_method_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/assign_top_m...
tests/language/assign_top_method_test.dart:11: Expect.throws(() { method = () {
return 1; }; }, /// 01: static type warning
//

https://codereview.chromium.org/2763823002/diff/1/tests/language/assignable_e...
File tests/language/assignable_expression_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/assignable_e...
tests/language/assignable_expression_test.dart:21: (C.static_field) = 0;   ///
11: compile-time error
//

https://codereview.chromium.org/2763823002/diff/1/tests/language/async_await_...
File tests/language/async_await_syntax_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/async_await_...
tests/language/async_await_syntax_test.dart:50: a06a() async { await for (var o
in st) {} }  /// a06a: ok
//

[Jacob, 2017-03-21 02:25:36]

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/23486_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/23486_test.dart:35: Expect.throws(() => new
D.name()); /// 02: continued
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/bounds_check_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/bounds_check_test.dart:14:
checkIndexedAssignment(a, 2);   /// 08: runtime error
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/int_index_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/int_index_test.dart:8: a[1.2] = 4; /// 02: runtime
error
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/label_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/label_test.dart:37: (() { break foo; })();  /// 07:
continued
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/minus_zero_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/minus_zero_test.dart:15: int i = MINUS_ZERO;  ///
01: continued
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/from_environm...
File tests/corelib/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/from_environm...
tests/corelib/from_environment_const_type_test.dart:11: bool   /// 01: ok
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/int_parse_rad...
File tests/corelib/int_parse_radix_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/int_parse_rad...
tests/corelib/int_parse_radix_test.dart:67: testParse(pow(i, 64) - 1, digit *
64, i);  /// 02: continued
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/int_parse_rad...
tests/corelib/int_parse_radix_test.dart:76:
Expect.equals(0x12345678123456781234567812345678,  /// 02: continued
On 2017/03/21 01:43:46, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/integer_to_st...
File tests/corelib/integer_to_string_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/integer_to_st...
tests/corelib/integer_to_string_test.dart:64: test(0xffffffffffffffff,
"18446744073709551615");   /// 01: continued
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_retu...
File tests/corelib/iterable_return_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_retu...
tests/corelib/iterable_return_type_test.dart:66: testList(new Uint8List(1)..[0]
= 1);   /// 01: ok
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_to_l...
File tests/corelib/iterable_to_list_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/iterable_to_l...
tests/corelib/iterable_to_list_test.dart:33: testIterable(new
Float32List.fromList([1.0, 2.0, 3.0]),  /// 01: continued
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
File tests/corelib/num_sign_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
tests/corelib/num_sign_test.dart:63: 2.2250738585072014e-308,  // min normal
On 2017/03/21 01:43:47, sra1 wrote:
> erk

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
tests/corelib/num_sign_test.dart:63: 2.2250738585072014e-308,  // min normal
On 2017/03/21 01:43:47, sra1 wrote:
> erk

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
tests/corelib/num_sign_test.dart:76: 1.7976931348623157e+308,  // max finite
double
On 2017/03/21 01:43:47, sra1 wrote:
> erk

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/num_sign_test...
tests/corelib/num_sign_test.dart:76: 1.7976931348623157e+308,  // max finite
double
On 2017/03/21 01:43:47, sra1 wrote:
> erk

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/regexp/captur...
File tests/corelib/regexp/capture-3_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/regexp/captur...
tests/corelib/regexp/capture-3_test.dart:68: NoHang(new
RegExp(r"(((.*)*)*Ā)foo"));  // Body of loop filtered.
On 2017/03/21 01:43:47, sra1 wrote:
> erk

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_operat...
File tests/corelib/symbol_operator_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_operat...
tests/corelib/symbol_operator_test.dart:31: testSymbolThrows(">>>");  /// 03: ok
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_reserv...
File tests/corelib/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/symbol_reserv...
tests/corelib/symbol_reserved_word_test.dart:22: checkBadSymbol('void.foo');  
/// 06: ok
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/uri_test.dart
File tests/corelib/uri_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib/uri_test.dart...
tests/corelib/uri_test.dart:502: // and no colon before slash in path.
On 2017/03/21 01:43:47, sra1 wrote:
> ??

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/from_e...
File tests/corelib_strong/from_environment_const_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/from_e...
tests/corelib_strong/from_environment_const_type_test.dart:11: bool   /// 01: ok
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/int_pa...
File tests/corelib_strong/int_parse_radix_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/int_pa...
tests/corelib_strong/int_parse_radix_test.dart:67: testParse(pow(i, 64) - 1,
digit * 64, i);  /// 02: continued
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/int_pa...
tests/corelib_strong/int_parse_radix_test.dart:76:
Expect.equals(0x12345678123456781234567812345678,  /// 02: continued
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/intege...
File tests/corelib_strong/integer_to_string_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/intege...
tests/corelib_strong/integer_to_string_test.dart:64: test(0xffffffffffffffff,
"18446744073709551615");   /// 01: continued
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/iterab...
File tests/corelib_strong/iterable_return_type_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/iterab...
tests/corelib_strong/iterable_return_type_test.dart:66: testList(new
Uint8List(1)..[0] = 1);   /// 01: ok
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/num_si...
File tests/corelib_strong/num_sign_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/num_si...
tests/corelib_strong/num_sign_test.dart:63: 2.2250738585072014e-308,  // min
normal
On 2017/03/21 01:43:47, sra1 wrote:
> ??

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/num_si...
tests/corelib_strong/num_sign_test.dart:76: 1.7976931348623157e+308,  // max
finite double
On 2017/03/21 01:43:47, sra1 wrote:
> ??

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/regexp...
File tests/corelib_strong/regexp/capture-3_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/regexp...
tests/corelib_strong/regexp/capture-3_test.dart:68: NoHang(new
RegExp(r"(((.*)*)*Ā)foo"));  // Body of loop filtered.
On 2017/03/21 01:43:47, sra1 wrote:
> ??

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
File tests/corelib_strong/symbol_operator_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
tests/corelib_strong/symbol_operator_test.dart:31: testSymbolThrows(">>>");  ///
03: ok
On 2017/03/21 01:43:48, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
tests/corelib_strong/symbol_operator_test.dart:31: testSymbolThrows(">>>");  ///
03: ok
On 2017/03/21 01:43:47, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
File tests/corelib_strong/symbol_reserved_word_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/symbol...
tests/corelib_strong/symbol_reserved_word_test.dart:28: x = const
Symbol('assert');   /// 10: compile-time error
On 2017/03/21 01:43:48, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/uri_te...
File tests/corelib_strong/uri_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/corelib_strong/uri_te...
tests/corelib_strong/uri_test.dart:217: // and no colon before slash in path.
On 2017/03/21 01:43:48, sra1 wrote:
> ??

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/isolate/remote_unitte...
File tests/isolate/remote_unittest_helper.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/isolate/remote_unitte...
tests/isolate/remote_unittest_helper.dart:20: * //       the usual test.
On 2017/03/21 01:43:48, sra1 wrote:
> ??

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_fac...
File tests/language/abstract_factory_constructor_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_fac...
tests/language/abstract_factory_constructor_test.dart:28: new A2.make(); //     
     /// 00: continued
On 2017/03/21 01:43:48, sra1 wrote:
> revert

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_run...
File tests/language/abstract_runtime_error_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/abstract_run...
tests/language/abstract_runtime_error_test.dart:40: "expected
AbstractClassInstantiationError");  /// 01: continued
On 2017/03/21 01:43:48, sra1 wrote:
> ??

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/language/arg_param_tr...
File tests/language/arg_param_trailing_comma_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/arg_param_tr...
tests/language/arg_param_trailing_comma_test.dart:43: void
afterFunsigDefaultValueY([void f() = topy,]) {}  /// none: continued
On 2017/03/21 01:43:48, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/language/assert_initi...
File tests/language/assert_initializer_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/assert_initi...
tests/language/assert_initializer_test.dart:39: const c = const
AssertArgument.constFirstSuper(false, 0, 1);  /// 05: compile-time error
On 2017/03/21 01:43:48, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/language/assign_top_m...
File tests/language/assign_top_method_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/assign_top_m...
tests/language/assign_top_method_test.dart:11: Expect.throws(() { method = () {
return 1; }; }, /// 01: static type warning
On 2017/03/21 01:43:48, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/language/assignable_e...
File tests/language/assignable_expression_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/assignable_e...
tests/language/assignable_expression_test.dart:21: (C.static_field) = 0;   ///
11: compile-time error
On 2017/03/21 01:43:48, sra1 wrote:
> //

Done.

https://codereview.chromium.org/2763823002/diff/1/tests/language/async_await_...
File tests/language/async_await_syntax_test.dart (right):

https://codereview.chromium.org/2763823002/diff/1/tests/language/async_await_...
tests/language/async_await_syntax_test.dart:50: a06a() async { await for (var o
in st) {} }  /// a06a: ok
On 2017/03/21 01:43:48, sra1 wrote:
> //

Done.

[sra1, 2017-03-21 03:01:10]

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/n...
File tests/language_strong/named_parameters_with_conversions_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/n...
tests/language_strong/named_parameters_with_conversions_test.dart:104:
checkException(() => a.foo2('c', a:111, c: 1));  // Bad name.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/n...
tests/language_strong/named_parameters_with_conversions_test.dart:125:
checkException(() => f2('c', a: 111, c: 1));  // Bad name.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/s...
File tests/language_strong/scope_variable_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/s...
tests/language_strong/scope_variable_test.dart:35: var c = a;  // Use of 'a'
prior to its shadow declaration below.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/s...
File tests/language_strong/switch_label_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/s...
tests/language_strong/switch_label_test.dart:92: Expect.equals(400,
s.say3("cow", "boeh"));  // Don't ask.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/async/run_zon...
File tests/lib/async/run_zoned6_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/async/run_zon...
tests/lib/async/run_zoned6_test.dart:17: if (false) /// 01: runtime error
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/convert/utf8_...
File tests/lib/convert/utf8_encode_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/convert/utf8_...
tests/lib/convert/utf8_encode_test.dart:41: Expect.throws(() =>
encoder.convert(ascii, 0, -1)); // end < 0
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/convert/utf8_...
File tests/lib/convert/utf8_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/convert/utf8_...
tests/lib/convert/utf8_test.dart:35: Expect.throws(() => decoder.convert(ascii,
0, 6));  // end > length
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/mirrors/metho...
File tests/lib/mirrors/method_mirror_source_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/mirrors/metho...
tests/lib/mirrors/method_mirror_source_test.dart:74: " //    Happy foo.\n"
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/typed_data/se...
File tests/lib/typed_data/setRange_5_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib/typed_data/se...
tests/lib/typed_data/setRange_5_test.dart:13: // a2:           p q r s t //     
       5 bytes
revert

or recognize actual start of comment

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/conver...
File tests/lib_strong/convert/utf8_encode_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/conver...
tests/lib_strong/convert/utf8_encode_test.dart:42: Expect.throws(() =>
encoder.convert(ascii, 0, 6));  // end > length
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/conver...
File tests/lib_strong/convert/utf8_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/conver...
tests/lib_strong/convert/utf8_test.dart:34: Expect.throws(() =>
decoder.convert(ascii, 0, 6));  // end > length
sp sp // -> sp // sp

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/mirror...
File tests/lib_strong/mirrors/method_mirror_source_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/mirror...
tests/lib_strong/mirrors/method_mirror_source_test.dart:74: " //    Happy
foo.\n"
revert

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/typed_...
File tests/lib_strong/typed_data/setRange_5_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/lib_strong/typed_...
tests/lib_strong/typed_data/setRange_5_test.dart:13: // a2:           p q r s t
//             5 bytes
revert

[sra1, 2017-03-21 03:28:15]

https://codereview.chromium.org/2763823002/diff/20001/tests/language/generic_...
File tests/language/generic_deep_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/generic_...
tests/language/generic_deep_test.dart:74: Expect.isTrue(NFromInt(4) is
!S<S<S<S<S>>>>);  // 4 < 5
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language/label6_n...
File tests/language/label6_negative_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/label6_n...
tests/language/label6_negative_test.dart:11: break L;  // ok
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language/named_pa...
File tests/language/named_parameters_with_conversions_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/named_pa...
tests/language/named_parameters_with_conversions_test.dart:104:
checkException(() => a.foo2('c', a:111, c: 1));  // Bad name.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language/optimize...
File tests/language/optimized_lists_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/optimize...
tests/language/optimized_lists_test.dart:19: var b = new List(10);  // Fixed
size list.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language/regress_...
File tests/language/regress_23051_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/regress_...
tests/language/regress_23051_test.dart:14: /// 01: continued
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language/runtime_...
File tests/language/runtime_type_function_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/runtime_...
tests/language/runtime_type_function_test.dart:28: check(fn('void',
'(dynamic)'), [].add);  // Instance tear-off.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language/super_op...
File tests/language/super_operator_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/super_op...
tests/language/super_operator_test.dart:71: a += "Tell"; //   operator + of
class B.
might as well revert this file

https://codereview.chromium.org/2763823002/diff/20001/tests/language/switch_c...
File tests/language/switch_case_warn_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/switch_c...
tests/language/switch_case_warn_test.dart:126: continue;  // Continue loop. ///
03: continued
fix?

https://codereview.chromium.org/2763823002/diff/20001/tests/language/switch_l...
File tests/language/switch_label_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/switch_l...
tests/language/switch_label_test.dart:92: Expect.equals(400, s.say3("cow",
"boeh"));  // Don't ask.
fix?

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/a...
File tests/language_strong/abstract_method_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/a...
tests/language_strong/abstract_method_test.dart:15: set height(int x);  //
Abstract instance setter.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/b...
File tests/language_strong/bit_operations_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/b...
tests/language_strong/bit_operations_test.dart:185: Expect.notEquals((a & (b ^
c)) | (d & (b ^ c)), result);  // ^&|
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/c...
File tests/language_strong/callable_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/c...
tests/language_strong/callable_test.dart:35: Function f = x;  // Should pass
checked mode test
fix?

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/c...
File tests/language_strong/constructor6_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/c...
tests/language_strong/constructor6_test.dart:26: E(arg += 100);  // If this is
the same arg as closed by f, ...
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/c...
File tests/language_strong/constructor7_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/c...
tests/language_strong/constructor7_test.dart:22: var i = 0;  // Initialized
odd/even to detect these inits affecting order.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/g...
File tests/language_strong/generic_deep_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/g...
tests/language_strong/generic_deep_test.dart:74: Expect.isTrue(NFromInt(4) is
!S<S<S<S<S>>>>);  // 4 < 5
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/l...
File tests/language_strong/label6_negative_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language_strong/l...
tests/language_strong/label6_negative_test.dart:11: break L;  // ok
fix

[sra1, 2017-03-21 03:39:29]

lgtm

https://codereview.chromium.org/2763823002/diff/20001/tests/compiler/dart2js_...
File tests/compiler/dart2js_native/browser_compat_1_prepatched_test.dart
(right):

https://codereview.chromium.org/2763823002/diff/20001/tests/compiler/dart2js_...
tests/compiler/dart2js_native/browser_compat_1_prepatched_test.dart:26: function
T1CrazyB() { }  // Native class with different constructor name.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib/list_test...
File tests/corelib/list_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib/list_test...
tests/corelib/list_test.dart:70: testIndexError(list, -0x123456789, name);  // <
-2^32.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib/num_sign_...
File tests/corelib/num_sign_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib/num_sign_...
tests/corelib/num_sign_test.dart:63: 2.2250738585072014e-308,  // min normal
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib/num_sign_...
tests/corelib/num_sign_test.dart:76: 1.7976931348623157e+308,  // max finite
double
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib/regexp/ca...
File tests/corelib/regexp/capture-3_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib/regexp/ca...
tests/corelib/regexp/capture-3_test.dart:69: NoHang(new
RegExp(r"Ā(((.*)*)*x)")); //   Everything after a filtered character is
filtered.
revert

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib_strong/li...
File tests/corelib_strong/list_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib_strong/li...
tests/corelib_strong/list_test.dart:70: testIndexError(list, -0x123456789,
name);  // < -2^32.
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib_strong/ur...
File tests/corelib_strong/uri_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/corelib_strong/ur...
tests/corelib_strong/uri_test.dart:251: // becomes ASCII lower-case in Turkish.
fix?

https://codereview.chromium.org/2763823002/diff/20001/tests/language/bit_oper...
File tests/language/bit_operations_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/bit_oper...
tests/language/bit_operations_test.dart:185: Expect.notEquals((a & (b ^ c)) | (d
& (b ^ c)), result);  // ^&|
fix

https://codereview.chromium.org/2763823002/diff/20001/tests/language/construc...
File tests/language/constructor6_test.dart (right):

https://codereview.chromium.org/2763823002/diff/20001/tests/language/construc...
tests/language/constructor6_test.dart:26: E(arg += 100);  // If this is the same
arg as closed by f, ...
fix

[Jacob, 2017-03-21 04:03:16]

Description was changed from

==========
Add comments


Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
==========

to

==========
Add comments


Add spaces to make sure dartfmt doesn't destroy bespoke indentation

BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6a7d6c385e7cfa2f86b832d0281bb217d86055fd
==========

[Jacob, 2017-03-21 04:03:19]

Committed patchset #2 (id:20001) manually as
6a7d6c385e7cfa2f86b832d0281bb217d86055fd (presubmit successful).