Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3903)

Unified Diff: services/ui/ws/frame_generator.cc

Issue 2763623002: [ui/ws] Acknowledge BeginFrames in FrameGenerator + add tests. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/frame_generator.cc
diff --git a/services/ui/ws/frame_generator.cc b/services/ui/ws/frame_generator.cc
index 41980cca1dbf0f6acdf4d41bc28ae71f093ceb64..df12724d89a05b3849115a8f9979d3910127209e 100644
--- a/services/ui/ws/frame_generator.cc
+++ b/services/ui/ws/frame_generator.cc
@@ -93,17 +93,24 @@ void FrameGenerator::SetExternalTilePriorityConstraints(
const gfx::Transform& transform) {}
void FrameGenerator::OnBeginFrame(const cc::BeginFrameArgs& begin_frame_args) {
+ current_begin_frame_ack_ = cc::BeginFrameAck(
+ begin_frame_args.source_id, begin_frame_args.sequence_number,
+ begin_frame_args.sequence_number, 0, false);
if (!root_window_->visible() ||
begin_frame_args.type == cc::BeginFrameArgs::MISSED) {
+ begin_frame_source_->DidFinishFrame(this, current_begin_frame_ack_);
return;
}
+ current_begin_frame_ack_.has_damage = true;
+ last_begin_frame_args_ = begin_frame_args;
+
// TODO(fsamuel): We should add a trace for generating a top level frame.
cc::CompositorFrame frame(GenerateCompositorFrame(root_window_->bounds()));
-
compositor_frame_sink_->SubmitCompositorFrame(std::move(frame));
+
+ begin_frame_source_->DidFinishFrame(this, current_begin_frame_ack_);
SetNeedsBeginFrame(false);
- last_begin_frame_args_ = begin_frame_args;
}
const cc::BeginFrameArgs& FrameGenerator::LastUsedBeginFrameArgs() const {
@@ -144,6 +151,7 @@ cc::CompositorFrame FrameGenerator::GenerateCompositorFrame(
frame.render_pass_list.push_back(std::move(invert_pass));
}
frame.metadata.device_scale_factor = device_scale_factor_;
+ frame.metadata.begin_frame_ack = current_begin_frame_ack_;
if (window_manager_surface_info_.is_valid()) {
frame.metadata.referenced_surfaces.push_back(

Powered by Google App Engine
This is Rietveld 408576698