Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2127)

Unified Diff: content/browser/background_fetch/background_fetch_data_manager_unittest.cc

Issue 2763613004: Use std::unique_ptr for access to BackgroundFetchJobInfo (Closed)
Patch Set: Missed one Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_data_manager_unittest.cc
diff --git a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
index 374d213d6c931602d29475eb3e2d50d8ec8be8fe..4565dbddee37935bb4777263c3ed92ec8782a6fa 100644
--- a/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
+++ b/content/browser/background_fetch/background_fetch_data_manager_unittest.cc
@@ -57,13 +57,14 @@ TEST_F(BackgroundFetchDataManagerTest, AddRequest) {
request_guids.push_back(request_info.guid());
request_infos.push_back(std::move(request_info));
}
- BackgroundFetchJobInfo job_info(kTag, url::Origin(GURL(kOrigin)),
- kServiceWorkerRegistrationId);
+ std::unique_ptr<BackgroundFetchJobInfo> job_info =
+ base::MakeUnique<BackgroundFetchJobInfo>(kTag, url::Origin(GURL(kOrigin)),
+ kServiceWorkerRegistrationId);
// Initialize a BackgroundFetchJobData with the constructed requests.
BackgroundFetchDataManager* data_manager = GetDataManager();
std::unique_ptr<BackgroundFetchJobData> job_data =
- data_manager->CreateRequest(job_info, request_infos);
+ data_manager->CreateRequest(std::move(job_info), request_infos);
// Get all of the fetch requests from the BackgroundFetchJobData.
for (int i = 0; i < 10; i++) {

Powered by Google App Engine
This is Rietveld 408576698