Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: content/browser/background_fetch/background_fetch_data_manager.h

Issue 2763613004: Use std::unique_ptr for access to BackgroundFetchJobInfo (Closed)
Patch Set: Missed one Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_data_manager.h
diff --git a/content/browser/background_fetch/background_fetch_data_manager.h b/content/browser/background_fetch/background_fetch_data_manager.h
index 9261abea1bb7ec39142e46471edf031505749591..4dd3a86873f71fe89f8c0c514637444bd457981b 100644
--- a/content/browser/background_fetch/background_fetch_data_manager.h
+++ b/content/browser/background_fetch/background_fetch_data_manager.h
@@ -6,6 +6,7 @@
#define CONTENT_BROWSER_BACKGROUND_FETCH_BACKGROUND_FETCH_DATA_MANAGER_H_
#include <map>
+#include <memory>
#include <string>
#include <unordered_map>
@@ -32,11 +33,11 @@ class CONTENT_EXPORT BackgroundFetchDataManager {
// Called by BackgroundFetchContext when a new request is started, this will
// store all of the necessary metadata to track the request.
std::unique_ptr<BackgroundFetchJobData> CreateRequest(
- const BackgroundFetchJobInfo& job_info,
+ std::unique_ptr<BackgroundFetchJobInfo> job_info,
BackgroundFetchRequestInfos request_infos);
private:
- void WriteJobToStorage(const BackgroundFetchJobInfo& job_info,
+ void WriteJobToStorage(std::unique_ptr<BackgroundFetchJobInfo> job_info,
BackgroundFetchRequestInfos request_infos);
BackgroundFetchRequestInfos& ReadRequestsFromStorage(
@@ -52,7 +53,8 @@ class CONTENT_EXPORT BackgroundFetchDataManager {
// Temporary map to hold data which will be written to storage.
// Map from job_guid to JobInfo.
- std::unordered_map<std::string, BackgroundFetchJobInfo> job_map_;
+ std::unordered_map<std::string, std::unique_ptr<BackgroundFetchJobInfo>>
+ job_map_;
// Map from job_guid to RequestInfos.
std::unordered_map<std::string, BackgroundFetchRequestInfos> request_map_;

Powered by Google App Engine
This is Rietveld 408576698