Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2763613002: Add DelayNavigationThrottle (Closed)
Patch Set: add dchecks Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index bce986334fa2352fc329e3b6ba463e219fedad9a..3eaa63ece4b587882a5635ae258a4a3acfe4cf6a 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -53,6 +53,7 @@
#include "chrome/browser/nacl_host/nacl_browser_delegate_impl.h"
#include "chrome/browser/net_benchmarking.h"
#include "chrome/browser/notifications/platform_notification_service_impl.h"
+#include "chrome/browser/page_load_metrics/experiments/delay_navigation_throttle.h"
#include "chrome/browser/page_load_metrics/metrics_navigation_throttle.h"
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include "chrome/browser/permissions/permission_context_base.h"
@@ -3359,6 +3360,16 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
content::NavigationHandle* handle) {
std::vector<std::unique_ptr<content::NavigationThrottle>> throttles;
+ // MetricsNavigationThrottle requires that it runs before NavigationThrottles
+ // that may delay or cancel navigations, so only NavigationThrottles that
+ // don't delay or cancel navigations (e.g. throttles that are only observing
+ // callbacks without affecting navigation behavior) should be added before
+ // MetricsNavigationThrottle.
+ if (handle->IsInMainFrame()) {
+ throttles.push_back(
+ page_load_metrics::MetricsNavigationThrottle::Create(handle));
+ }
+
#if BUILDFLAG(ENABLE_PLUGINS)
std::unique_ptr<content::NavigationThrottle> flash_url_throttle =
FlashDownloadInterception::MaybeCreateThrottleFor(handle);
@@ -3366,11 +3377,6 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
throttles.push_back(std::move(flash_url_throttle));
#endif
- if (handle->IsInMainFrame()) {
- throttles.push_back(
- page_load_metrics::MetricsNavigationThrottle::Create(handle));
- }
-
#if defined(OS_ANDROID)
// TODO(davidben): This is insufficient to integrate with prerender properly.
// https://crbug.com/370595
@@ -3426,6 +3432,11 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(
base::MakeUnique<extensions::ExtensionNavigationThrottle>(handle));
#endif
+ std::unique_ptr<content::NavigationThrottle> delay_navigation_throttle =
+ DelayNavigationThrottle::MaybeCreateThrottleFor(handle);
+ if (delay_navigation_throttle)
+ throttles.push_back(std::move(delay_navigation_throttle));
+
return throttles;
}
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/page_load_metrics/experiments/delay_navigation_throttle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698