Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: src/runtime/runtime-wasm.cc

Issue 2763593002: [wasm][arm] Add an additional stack check for functions with big frames. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-wasm.cc
diff --git a/src/runtime/runtime-wasm.cc b/src/runtime/runtime-wasm.cc
index 9320c800acfb90d5cd6f291917dd4d31d74e5be4..a8675b50e5a1a2026c518f0d38004ca50a7d4c90 100644
--- a/src/runtime/runtime-wasm.cc
+++ b/src/runtime/runtime-wasm.cc
@@ -136,6 +136,15 @@ RUNTIME_FUNCTION(Runtime_ThrowWasmError) {
return ThrowRuntimeError(isolate, message_id, byte_offset, true);
}
+RUNTIME_FUNCTION(Runtime_ThrowWasmStackOverflow) {
+ HandleScope scope(isolate);
+ DCHECK_NULL(isolate->context());
+ isolate->set_context(GetWasmContextOnStackTop(isolate));
+ SealHandleScope shs(isolate);
Michael Starzinger 2017/03/20 14:54:51 nit: The {Isolate::StackOverflow} method creates i
ahaas 2017/03/20 15:16:23 I removed the HandleScope and moved the SealHandle
+ DCHECK_LE(0, args.length());
Michael Starzinger 2017/03/20 14:54:51 nit: DCHECK_EQ? Also, please move the check up to
ahaas 2017/03/20 15:16:23 Done.
+ return isolate->StackOverflow();
+}
+
RUNTIME_FUNCTION(Runtime_WasmThrowTypeError) {
HandleScope scope(isolate);
DCHECK_EQ(0, args.length());
« no previous file with comments | « src/runtime/runtime.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698