Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: src/compiler/js-generic-lowering.cc

Issue 2763533002: [WIP] JSForInLowering and JSForInHasOwnProperty.
Patch Set: Hack around the issue with indices not being available always. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-for-in-lowering.cc ('k') | src/compiler/js-native-context-specialization.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-generic-lowering.cc
diff --git a/src/compiler/js-generic-lowering.cc b/src/compiler/js-generic-lowering.cc
index da4596a1ab01c000e38e3ebf601a508eae8919f2..7680810be71dd89d00eebc7207628878bb1c0700 100644
--- a/src/compiler/js-generic-lowering.cc
+++ b/src/compiler/js-generic-lowering.cc
@@ -593,16 +593,20 @@ void JSGenericLowering::LowerJSConvertReceiver(Node* node) {
ReplaceWithRuntimeCall(node, Runtime::kConvertReceiver);
}
+void JSGenericLowering::LowerJSForInHasOwnProperty(Node* node) {
+ UNREACHABLE(); // Eliminated in JSForInLowering.
+}
+
+void JSGenericLowering::LowerJSForInLoadProperty(Node* node) {
+ UNREACHABLE(); // Eliminated in JSForInLowering.
+}
+
void JSGenericLowering::LowerJSForInNext(Node* node) {
- CallDescriptor::Flags flags = FrameStateFlagForCall(node);
- Callable callable = CodeFactory::ForInNext(isolate());
- ReplaceWithStubCall(node, callable, flags);
+ UNREACHABLE(); // Eliminated in JSForInLowering.
}
void JSGenericLowering::LowerJSForInPrepare(Node* node) {
- CallDescriptor::Flags flags = FrameStateFlagForCall(node);
- Callable callable = CodeFactory::ForInPrepare(isolate());
- ReplaceWithStubCall(node, callable, flags, node->op()->properties(), 3);
+ UNREACHABLE(); // Eliminated in JSForInLowering.
}
void JSGenericLowering::LowerJSLoadMessage(Node* node) {
« no previous file with comments | « src/compiler/js-for-in-lowering.cc ('k') | src/compiler/js-native-context-specialization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698