Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5501)

Unified Diff: chrome/browser/chromeos/events/event_rewriter_unittest.cc

Issue 2763483002: Fix Caps Lock bug (Closed)
Patch Set: Failure due to file directory change, apply the fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/accelerators/accelerator_table_unittest.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/events/event_rewriter_unittest.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter_unittest.cc b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
index e77bf975689b643c6b9474306e0bacb60e7a8c6e..e76010d07431ddad53a64d238b45d42cd57e8467 100644
--- a/chrome/browser/chromeos/events/event_rewriter_unittest.cc
+++ b/chrome/browser/chromeos/events/event_rewriter_unittest.cc
@@ -979,10 +979,7 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapToCapsLock) {
search.Init(prefs::kLanguageRemapSearchKeyTo, prefs());
search.SetValue(chromeos::input_method::kCapsLockKey);
- chromeos::input_method::FakeImeKeyboard ime_keyboard;
rewriter_->KeyboardDeviceAddedForTesting(kKeyboardDeviceId, "PC Keyboard");
- rewriter_->set_ime_keyboard_for_testing(&ime_keyboard);
- EXPECT_FALSE(ime_keyboard.caps_lock_is_enabled_);
// Press Search.
EXPECT_EQ(GetExpectedResultAsString(
@@ -991,8 +988,6 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapToCapsLock) {
GetRewrittenEventAsString(rewriter_, ui::ET_KEY_PRESSED,
ui::VKEY_LWIN, ui::DomCode::META_LEFT,
ui::EF_COMMAND_DOWN, ui::DomKey::META));
- // Confirm that the Caps Lock status is changed.
- EXPECT_TRUE(ime_keyboard.caps_lock_is_enabled_);
// Release Search.
EXPECT_EQ(GetExpectedResultAsString(ui::ET_KEY_RELEASED, ui::VKEY_CAPITAL,
@@ -1001,8 +996,6 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapToCapsLock) {
GetRewrittenEventAsString(rewriter_, ui::ET_KEY_RELEASED,
ui::VKEY_LWIN, ui::DomCode::META_LEFT,
ui::EF_NONE, ui::DomKey::META));
- // Confirm that the Caps Lock status is not changed.
- EXPECT_TRUE(ime_keyboard.caps_lock_is_enabled_);
// Press Search.
EXPECT_EQ(GetExpectedResultAsString(
@@ -1012,8 +1005,6 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapToCapsLock) {
ui::VKEY_LWIN, ui::DomCode::META_LEFT,
ui::EF_COMMAND_DOWN | ui::EF_CAPS_LOCK_ON,
ui::DomKey::META));
- // Confirm that the Caps Lock status is changed.
- EXPECT_FALSE(ime_keyboard.caps_lock_is_enabled_);
// Release Search.
EXPECT_EQ(GetExpectedResultAsString(ui::ET_KEY_RELEASED, ui::VKEY_CAPITAL,
@@ -1022,8 +1013,6 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapToCapsLock) {
GetRewrittenEventAsString(rewriter_, ui::ET_KEY_RELEASED,
ui::VKEY_LWIN, ui::DomCode::META_LEFT,
ui::EF_NONE, ui::DomKey::META));
- // Confirm that the Caps Lock status is not changed.
- EXPECT_FALSE(ime_keyboard.caps_lock_is_enabled_);
// Press Caps Lock (on an external keyboard).
EXPECT_EQ(GetExpectedResultAsString(
@@ -1034,18 +1023,6 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapToCapsLock) {
ui::EF_CAPS_LOCK_ON | ui::EF_MOD3_DOWN,
ui::DomKey::CAPS_LOCK));
-#if defined(USE_X11)
- // Confirm that calling RewriteForTesting() does not change the state of
- // |ime_keyboard|. In this case, X Window system itself should change the
- // Caps Lock state, not ash::EventRewriter.
- EXPECT_FALSE(ime_keyboard.caps_lock_is_enabled_);
-#elif defined(USE_OZONE)
- // Under Ozone the rewriter is responsible for changing the caps lock
- // state when the final key is Caps Lock, regardless of whether the
- // initial key is Caps Lock.
- EXPECT_TRUE(ime_keyboard.caps_lock_is_enabled_);
-#endif
-
// Release Caps Lock (on an external keyboard).
EXPECT_EQ(GetExpectedResultAsString(ui::ET_KEY_RELEASED, ui::VKEY_CAPITAL,
ui::DomCode::CAPS_LOCK, ui::EF_NONE,
@@ -1053,11 +1030,6 @@ TEST_F(EventRewriterTest, TestRewriteModifiersRemapToCapsLock) {
GetRewrittenEventAsString(rewriter_, ui::ET_KEY_RELEASED,
ui::VKEY_CAPITAL, ui::DomCode::CAPS_LOCK,
ui::EF_NONE, ui::DomKey::CAPS_LOCK));
-#if defined(USE_X11)
- EXPECT_FALSE(ime_keyboard.caps_lock_is_enabled_);
-#elif defined(USE_OZONE)
- EXPECT_TRUE(ime_keyboard.caps_lock_is_enabled_);
-#endif
}
TEST_F(EventRewriterTest, TestRewriteCapsLock) {
@@ -1075,7 +1047,6 @@ TEST_F(EventRewriterTest, TestRewriteCapsLock) {
GetRewrittenEventAsString(rewriter_, ui::ET_KEY_PRESSED,
ui::VKEY_F16, ui::DomCode::F16,
ui::EF_MOD3_DOWN, ui::DomKey::F16));
- EXPECT_TRUE(ime_keyboard.caps_lock_is_enabled_);
}
TEST_F(EventRewriterTest, TestRewriteDiamondKey) {
« no previous file with comments | « ash/accelerators/accelerator_table_unittest.cc ('k') | ui/base/ime/input_method_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698