Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1692)

Unified Diff: ash/accelerators/accelerator_controller_unittest.cc

Issue 2763483002: Fix Caps Lock bug (Closed)
Patch Set: Add unit test for Caps Lock in accelerator. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/accelerators/accelerator_controller_unittest.cc
diff --git a/ash/accelerators/accelerator_controller_unittest.cc b/ash/accelerators/accelerator_controller_unittest.cc
index 2a5d178a1b2d8720b7396a531403dd3aa9d418a0..8f2f1e5d57bc5e8795ff1b69a1febe72fbcd33a7 100644
--- a/ash/accelerators/accelerator_controller_unittest.cc
+++ b/ash/accelerators/accelerator_controller_unittest.cc
@@ -980,7 +980,7 @@ class ToggleCapsLockTest : public AcceleratorControllerTest {
DISALLOW_COPY_AND_ASSIGN(ToggleCapsLockTest);
};
-// Tests the four combinations of the TOGGLE_CAPS_LOCK accelerator.
+// Tests the five combinations of the TOGGLE_CAPS_LOCK accelerator.
TEST_F(ToggleCapsLockTest, ToggleCapsLockAccelerators) {
chromeos::input_method::InputMethodManager* input_method_manager =
chromeos::input_method::InputMethodManager::Get();
@@ -1020,6 +1020,15 @@ TEST_F(ToggleCapsLockTest, ToggleCapsLockAccelerators) {
EXPECT_FALSE(ProcessInController(press_search_then_alt));
EXPECT_TRUE(ProcessInController(release_alt_before_search));
EXPECT_TRUE(input_method_manager->GetImeKeyboard()->CapsLockIsEnabled());
+ input_method_manager->GetImeKeyboard()->SetCapsLockEnabled(false);
+
+ // 5. Press Caps Lock, Release Caps Lock.
+ const ui::Accelerator press_caps_lock(ui::VKEY_CAPITAL, ui::EF_NONE);
+ EXPECT_FALSE(ProcessInController(press_caps_lock));
afakhry 2017/04/07 23:31:42 Can you check here the status of the caps lock has
weidongg 2017/04/08 00:15:07 Done.
+ const ui::Accelerator release_caps_lock(
+ CreateReleaseAccelerator(ui::VKEY_CAPITAL, ui::EF_NONE));
+ EXPECT_TRUE(ProcessInController(release_caps_lock));
+ EXPECT_TRUE(input_method_manager->GetImeKeyboard()->CapsLockIsEnabled());
}
class PreferredReservedAcceleratorsTest : public test::AshTestBase {
« no previous file with comments | « no previous file | ash/common/accelerators/accelerator_controller.cc » ('j') | ash/common/accelerators/accelerator_controller.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698