Fix Caps Lock bug

ui/events/event.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/event.h"
 
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 
@@ skipping 1138 matching lines @@
   }
   CHECK_EQ(ui::ET_KEY_PRESSED, event.type());
   if (!last_key_event_) {
     last_key_event_ = new KeyEvent(event);
     return false;
   } else if (event.time_stamp() == last_key_event_->time_stamp()) {
     // The KeyEvent is created from the same native event.
     return (last_key_event_->flags() & ui::EF_IS_REPEAT) != 0;
   }
   if (event.key_code() == last_key_event_->key_code() &&
-      event.flags() == (last_key_event_->flags() & ~ui::EF_IS_REPEAT) &&
+      // Ignore Caps Lock flag. Otherwise, Caps Lock toggles continuously
+      // when the key is hold down.
+      (event.flags() & ~ui::EF_CAPS_LOCK_ON) ==
+          (last_key_event_->flags() & ~ui::EF_IS_REPEAT &
+           ~ui::EF_CAPS_LOCK_ON) &&

[afakhry, 2017/03/21 17:09:22]

This doesn't look right. Clearing the CAPS LOCK flag on both sides of the == to
make them equal when they're not seems weird to me. Let's talk about this in
person as to why you need this.

       (event.time_stamp() - last_key_event_->time_stamp()).InMilliseconds() <
           kMaxAutoRepeatTimeMs) {
     last_key_event_->set_time_stamp(event.time_stamp());
     last_key_event_->set_flags(last_key_event_->flags() | ui::EF_IS_REPEAT);
     return true;
   }
   delete last_key_event_;
   last_key_event_ = new KeyEvent(event);
   return false;
 }
@@ skipping 295 matching lines @@
                    flags | EF_FROM_TOUCH),
       details_(details),
       unique_touch_event_id_(unique_touch_event_id) {
   latency()->set_source_event_type(ui::SourceEventType::TOUCH);
 }
 
 GestureEvent::~GestureEvent() {
 }
 
 }  // namespace ui