Fix Caps Lock bug

ui/chromeos/events/event_rewriter_chromeos.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/chromeos/events/event_rewriter_chromeos.h"
 
 #include <stddef.h>
 
 #include <vector>
 
@@ skipping 786 matching lines @@
     state->flags &= ~characteristic_flag;
     if (non_modifier_to_modifier)
       pressed_modifier_latches_ &= ~characteristic_flag;
   }
 
   if (key_event.type() == ui::ET_KEY_PRESSED) {
     if (!ui::KeycodeConverter::IsDomKeyForModifier(state->key)) {
       used_modifier_latches_ |= pressed_modifier_latches_;
       latched_modifier_latches_ = ui::EF_NONE;
     }
-    // Toggle Caps Lock if the remapped key is ui::VKEY_CAPITAL.
-    if (state->key_code == ui::VKEY_CAPITAL
-        // ... except on linux Chrome OS, where InputMethodChromeOS handles it.
-        && (base::SysInfo::IsRunningOnChromeOS() || ime_keyboard_for_testing_)
-#if defined(USE_X11)
-        // ... but for X11, do nothing if the original key is ui::VKEY_CAPITAL
-        // (i.e. a Caps Lock key on an external keyboard is pressed) since X
-        // handles that itself.
-        && incoming.key_code != ui::VKEY_CAPITAL
-#endif

[oshima, 2017/04/11 19:04:47]

Did you consult with the author of this code? Please include the resolution in
the bug description as well as comment in the code. (e.g. 
 This doesn't work on X11 because .....)

[kpschoedel, 2017/04/11 21:56:00]

(original author) I believe this can be removed because all ChromeOS platforms
now use Ozone/Freon and the X11 case is no longer used.

[oshima, 2017/04/11 22:24:54]

Many ChromeOS UI devs are still using linux+x11 desktop environment to develop
and test UI, so it's good to mention that this won't work on x11 somewhere.

[weidongg, 2017/04/11 22:55:43]

I am sorry, I am still confused  about these terms.
X11 is displaying server only used for build running on desktop?
Ozone is abstraction layer for low level input and it is only used in chromebook
device?
What is linux+x11 desktop environment? Is this like a virtual machine that runs
chrome build?

-        ) {
-      ::chromeos::input_method::ImeKeyboard* ime_keyboard =
-          ime_keyboard_for_testing_
-              ? ime_keyboard_for_testing_
-              : ::chromeos::input_method::InputMethodManager::Get()
-                    ->GetImeKeyboard();
-      ime_keyboard->SetCapsLockEnabled(!ime_keyboard->CapsLockIsEnabled());
-    }
   }
   return exact_event;
 }
 
 void EventRewriterChromeOS::RewriteNumPadKeys(const ui::KeyEvent& key_event,
                                               MutableKeyState* state) {
   DCHECK(key_event.type() == ui::ET_KEY_PRESSED ||
          key_event.type() == ui::ET_KEY_RELEASED);
   static const struct NumPadRemapping {
     ui::KeyboardCode input_key_code;
@@ skipping 300 matching lines @@
   for (const auto& keyboard : keyboard_devices) {
     if (keyboard.id == device_id) {
       return KeyboardDeviceAddedInternal(
           keyboard.id, keyboard.name, keyboard.vendor_id, keyboard.product_id);
     }
   }
   return kDeviceUnknown;
 }
 
 }  // namespace ui