Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2763453002: [ServiceWorker] Convert ping-pong IPC into mojo interface ServiceWorkerEventDispatcher (Closed)
Patch Set: Add a comment into mojom file Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index 838a19b4e2ae3d161a2dc0d9e10c1fe307ab95fb..83fb82d6d3c5d01cc7f0f3793decb8889dc0f23d 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -419,7 +419,6 @@ void ServiceWorkerContextClient::OnMessageReceived(
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidSkipWaiting, OnDidSkipWaiting)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_DidClaimClients, OnDidClaimClients)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ClaimClientsError, OnClaimClientsError)
- IPC_MESSAGE_HANDLER(ServiceWorkerMsg_Ping, OnPing);
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
DCHECK(handled);
@@ -1263,8 +1262,8 @@ void ServiceWorkerContextClient::OnClaimClientsError(
context_->claim_clients_callbacks.Remove(request_id);
}
-void ServiceWorkerContextClient::OnPing() {
- Send(new ServiceWorkerHostMsg_Pong(GetRoutingID()));
+void ServiceWorkerContextClient::Ping(const PingCallback& callback) {
+ callback.Run();
}
void ServiceWorkerContextClient::OnNavigationPreloadResponse(

Powered by Google App Engine
This is Rietveld 408576698