MD Settings: Fix endless recursion when exiting CBD dialog.

chrome/browser/resources/settings/route.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /**
    * Class for navigable routes. May only be instantiated within this file.
    * @constructor
    * @param {string} path
    * @private
@@ skipping 351 matching lines @@
 
   /**
    * Navigates to a canonical route and pushes a new history entry.
    * @param {!settings.Route} route
    * @param {URLSearchParams=} opt_dynamicParameters Navigations to the same
    *     URL parameters in a different order will still push to history.
    * @param {boolean=} opt_removeSearch Whether to strip the 'search' URL
    *     parameter during navigation. Defaults to false.
    */
   var navigateTo = function(route, opt_dynamicParameters, opt_removeSearch) {
+    // The ADVANCED route only serves as a parent of subpages, and should not
+    // be possible to navigate to it directly.
+    if (route == settings.Route.ADVANCED)
+      route = settings.Route.BASIC;
+
     var params = opt_dynamicParameters || new URLSearchParams();
     var removeSearch = !!opt_removeSearch;
 
     var oldSearchParam = getQueryParameters().get('search') || '';
     var newSearchParam = params.get('search') || '';
 
     if (!removeSearch && oldSearchParam && !newSearchParam)
       params.append('search', oldSearchParam);
 
     var url = route.path;
@@ skipping 34 matching lines @@
     getRouteForPath: getRouteForPath,
     initializeRouteFromUrl: initializeRouteFromUrl,
     resetRouteForTesting: resetRouteForTesting,
     getCurrentRoute: getCurrentRoute,
     getQueryParameters: getQueryParameters,
     lastRouteChangeWasPopstate: lastRouteChangeWasPopstate,
     navigateTo: navigateTo,
     navigateToPreviousRoute: navigateToPreviousRoute,
   };
 });