Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2763413008: Add U2F device enumeration class (Closed)

Created:
3 years, 9 months ago by Casey Piper
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add U2F device enumeration class U2f devices can be distinguished by the HID usage page. This adds support to enumerate all connected u2f devices. BUG=686310

Patch Set 1 #

Patch Set 2 : Use modern callbacks and add unittest #

Patch Set 3 : Remove include of nonexistant file #

Patch Set 4 : Fix issues causing crash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -3 lines) Patch
M device/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/u2f/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M device/u2f/u2f_device.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A device/u2f/u2f_enumerate.h View 1 1 chunk +54 lines, -0 lines 0 comments Download
A device/u2f/u2f_enumerate.cc View 1 1 chunk +52 lines, -0 lines 0 comments Download
A device/u2f/u2f_enumerate_unittest.cc View 1 2 3 1 chunk +87 lines, -0 lines 0 comments Download
M device/u2f/u2f_hid_device.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M device/u2f/u2f_hid_device.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2771673002 Patch 180001

Messages

Total messages: 28 (28 generated)
Casey Piper
Description was changed from ========== Add U2F device enumeration class U2f devices can be distinguished ...
3 years, 9 months ago (2017-03-25 00:09:38 UTC) #1
Casey Piper
piperc@chromium.org changed reviewers: + kpaulhamus@chromium.org
3 years, 9 months ago (2017-03-25 00:09:38 UTC) #2
Casey Piper
The CQ bit was checked by piperc@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-03-25 00:09:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763413008/1
3 years, 9 months ago (2017-03-25 00:10:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-03-25 00:15:10 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/335940) linux_chromium_chromeos_ozone_rel_ng on ...
3 years, 9 months ago (2017-03-25 00:15:11 UTC) #6
Casey Piper
Patchset #2 (id:20001) has been deleted
3 years, 8 months ago (2017-03-29 23:05:50 UTC) #7
Casey Piper
The CQ bit was checked by piperc@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-29 23:06:22 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763413008/40001
3 years, 8 months ago (2017-03-29 23:07:21 UTC) #9
Casey Piper
piperc@chromium.org changed reviewers: + reillyg@chromium.org
3 years, 8 months ago (2017-03-29 23:07:36 UTC) #10
Casey Piper
piperc@chromium.org changed required reviewers: + reillyg@chromium.org
3 years, 8 months ago (2017-03-29 23:07:37 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-29 23:18:42 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/42414) mac_chromium_compile_dbg_ng on ...
3 years, 8 months ago (2017-03-29 23:18:43 UTC) #13
Casey Piper
The CQ bit was checked by piperc@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-03-29 23:35:21 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763413008/60001
3 years, 8 months ago (2017-03-29 23:36:39 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-03-30 00:36:37 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/417885)
3 years, 8 months ago (2017-03-30 00:36:38 UTC) #17
Casey Piper
Patchset #4 (id:80001) has been deleted
3 years, 8 months ago (2017-04-01 00:13:47 UTC) #18
Casey Piper
The CQ bit was checked by piperc@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-01 00:13:58 UTC) #19
Casey Piper
The CQ bit was unchecked by piperc@chromium.org
3 years, 8 months ago (2017-04-01 00:14:21 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763413008/100001
3 years, 8 months ago (2017-04-01 00:14:27 UTC) #21
Casey Piper
Patchset #4 (id:100001) has been deleted
3 years, 8 months ago (2017-04-01 00:16:37 UTC) #22
Casey Piper
The CQ bit was checked by piperc@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-01 00:16:56 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763413008/120001
3 years, 8 months ago (2017-04-01 00:17:26 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-01 02:05:18 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-01 02:05:19 UTC) #26
Casey Piper
piperc@chromium.org changed reviewers: - kpaulhamus@chromium.org, reillyg@chromium.org
3 years, 8 months ago (2017-04-17 22:23:50 UTC) #27
Casey Piper
3 years, 8 months ago (2017-04-17 22:23:50 UTC) #28 
piperc@chromium.org changed required reviewers:
- reillyg@chromium.org

Powered by Google App Engine
This is Rietveld 408576698