Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: net/url_request/sdch_dictionary_fetcher.cc

Issue 2763393002: Remove stale-while-revalidate from net (Closed)
Patch Set: fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_response_info_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/sdch_dictionary_fetcher.cc
diff --git a/net/url_request/sdch_dictionary_fetcher.cc b/net/url_request/sdch_dictionary_fetcher.cc
index 9d557f185ba4f570d22b2f1098c6bcf8d166eea9..e51d9581a055c4bffc637d03564cd89b4a5f7305 100644
--- a/net/url_request/sdch_dictionary_fetcher.cc
+++ b/net/url_request/sdch_dictionary_fetcher.cc
@@ -167,12 +167,10 @@ void SdchDictionaryFetcher::OnResponseStarted(URLRequest* request,
// HTTP, it is presumed to be fresh.
HttpResponseHeaders* response_headers = request->response_headers();
if (net_error == OK && response_headers) {
- ValidationType validation_type = response_headers->RequiresValidation(
+ bool requires_validation = response_headers->RequiresValidation(
request->response_info().request_time,
request->response_info().response_time, base::Time::Now());
- // TODO(rdsmith): Maybe handle VALIDATION_ASYNCHRONOUS by queueing
- // a non-reload request for the dictionary.
- if (validation_type != VALIDATION_NONE)
+ if (requires_validation)
net_error = ERR_FAILED;
}
« no previous file with comments | « net/http/http_response_info_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698