Switching AudioInputDeviceManager from using AudioManager interface to AudioSystem one.

content/browser/renderer_host/media/audio_input_device_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/audio_input_device_manager.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <string>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "build/build_config.h"
 #include "content/public/common/media_stream_request.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "media/audio/audio_manager_base.h"
+#include "media/audio/audio_system_impl.h"
 #include "media/base/media_switches.h"
+#include "media/base/test_helpers.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::InSequence;
 
 namespace content {
 
 class MockAudioInputDeviceManagerListener
     : public MediaStreamProviderListener {
  public:
@@ skipping 14 matching lines @@
 
 // TODO(henrika): there are special restrictions for Android since
 // AudioInputDeviceManager::Open() must be called on the audio thread.
 // This test suite must be modified to run on Android.
 #if defined(OS_ANDROID)
 #define MAYBE_AudioInputDeviceManagerTest DISABLED_AudioInputDeviceManagerTest
 #else
 #define MAYBE_AudioInputDeviceManagerTest AudioInputDeviceManagerTest
 #endif
 
 class MAYBE_AudioInputDeviceManagerTest : public testing::Test {

[DaleCurtis, 2017/03/28 18:22:11]

Hmm, does MAYBE actually work as a classname? I thought DISABLED_/MAYBE_ only
work as the test name not the test class name.

[o1ka, 2017/03/30 15:11:53]

Looks like it does:
https://github.com/google/googletest/blob/master/googletest/docs/V1_7_Advance...:

"If you need to disable all tests in a test case, you can either add DISABLED_
to the front of the name of each test, or alternatively add it to the front of
the test case name"

  public:
-  MAYBE_AudioInputDeviceManagerTest() {}
+  MAYBE_AudioInputDeviceManagerTest() : audio_thread_("AudioSystemThread") {
+    audio_thread_.StartAndWaitForTesting();
+  }
 
  protected:
   void SetUp() override {
     base::CommandLine::ForCurrentProcess()->AppendSwitch(
         switches::kUseFakeDeviceForMediaStream);
-    audio_manager_ = media::AudioManager::CreateForTesting(
-        base::ThreadTaskRunnerHandle::Get());
+    audio_manager_ =
+        media::AudioManager::CreateForTesting(audio_thread_.task_runner());
     // Flush the message loop to ensure proper initialization of AudioManager.
     base::RunLoop().RunUntilIdle();
 
-    manager_ = new AudioInputDeviceManager(audio_manager_.get());
+    audio_system_ = media::AudioSystemImpl::Create(audio_manager_.get());
+    manager_ = new AudioInputDeviceManager(audio_system_.get());
     audio_input_listener_.reset(new MockAudioInputDeviceManagerListener());
     manager_->RegisterListener(audio_input_listener_.get());
 
     // Use fake devices.
     devices_.emplace_back(MEDIA_DEVICE_AUDIO_CAPTURE, "Fake Device 1",
                           "fake_device_1");
     devices_.emplace_back(MEDIA_DEVICE_AUDIO_CAPTURE, "Fake Device 2",
                           "fake_device_2");
 
     // Wait until we get the list.
     base::RunLoop().RunUntilIdle();
   }
 
   void TearDown() override {
     manager_->UnregisterListener(audio_input_listener_.get());
+    audio_system_.reset();
+    audio_manager_.reset();
+    audio_thread_.Stop();
+  }
+
+  void WaitForOpenCompletion() {
+    media::WaitableMessageLoopEvent event;
+    audio_thread_.task_runner()->PostTaskAndReply(
+        FROM_HERE, base::Bind(&base::DoNothing), event.GetClosure());
+    // Runs the loop and waits for the |audio_thread_| to call event's
+    // closure.
+    event.RunAndWait();
+    base::RunLoop().RunUntilIdle();
   }
 
   TestBrowserThreadBundle thread_bundle_;
+  base::Thread audio_thread_;
   scoped_refptr<AudioInputDeviceManager> manager_;
   std::unique_ptr<MockAudioInputDeviceManagerListener> audio_input_listener_;
   media::ScopedAudioManagerPtr audio_manager_;
+  std::unique_ptr<media::AudioSystem> audio_system_;
   StreamDeviceInfoArray devices_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MAYBE_AudioInputDeviceManagerTest);
 };
 
 // Opens and closes the devices.
 TEST_F(MAYBE_AudioInputDeviceManagerTest, OpenAndCloseDevice) {
   ASSERT_FALSE(devices_.empty());
 
   InSequence s;
 
   for (StreamDeviceInfoArray::const_iterator iter = devices_.begin();
        iter != devices_.end(); ++iter) {
     // Opens/closes the devices.
     int session_id = manager_->Open(iter->device);
 
     // Expected mock call with expected return value.
     EXPECT_CALL(*audio_input_listener_,
                 Opened(MEDIA_DEVICE_AUDIO_CAPTURE, session_id))
         .Times(1);
     // Waits for the callback.
-    base::RunLoop().RunUntilIdle();
+    WaitForOpenCompletion();
 
     manager_->Close(session_id);
     EXPECT_CALL(*audio_input_listener_,
                 Closed(MEDIA_DEVICE_AUDIO_CAPTURE, session_id))
         .Times(1);
 
     // Waits for the callback.
     base::RunLoop().RunUntilIdle();
   }
 }
@@ skipping 12 matching lines @@
        iter != devices_.end(); ++iter, ++index) {
     // Opens the devices.
     session_id[index] = manager_->Open(iter->device);
 
     // Expected mock call with expected returned value.
     EXPECT_CALL(*audio_input_listener_,
                 Opened(MEDIA_DEVICE_AUDIO_CAPTURE, session_id[index]))
         .Times(1);
 
     // Waits for the callback.
-    base::RunLoop().RunUntilIdle();
+    WaitForOpenCompletion();
   }
 
   // Checks if the session_ids are unique.
   for (size_t i = 0; i < devices_.size() - 1; ++i) {
     for (size_t k = i + 1; k < devices_.size(); ++k) {
       EXPECT_TRUE(session_id[i] != session_id[k]);
     }
   }
 
   for (size_t i = 0; i < devices_.size(); ++i) {
@@ skipping 16 matching lines @@
   std::string device_name("device_doesnt_exist");
   std::string device_id("id_doesnt_exist");
   MediaStreamDevice dummy_device(stream_type, device_id, device_name);
 
   int session_id = manager_->Open(dummy_device);
   EXPECT_CALL(*audio_input_listener_,
               Opened(MEDIA_DEVICE_AUDIO_CAPTURE, session_id))
       .Times(1);
 
   // Waits for the callback.
-  base::RunLoop().RunUntilIdle();
+  WaitForOpenCompletion();
 }
 
 // Opens default device twice.
 TEST_F(MAYBE_AudioInputDeviceManagerTest, OpenDeviceTwice) {
   ASSERT_FALSE(devices_.empty());
 
   InSequence s;
 
   // Opens and closes the default device twice.
   int first_session_id = manager_->Open(devices_.front().device);
   int second_session_id = manager_->Open(devices_.front().device);
 
   // Expected mock calls with expected returned values.
   EXPECT_NE(first_session_id, second_session_id);
   EXPECT_CALL(*audio_input_listener_,
               Opened(MEDIA_DEVICE_AUDIO_CAPTURE, first_session_id))
       .Times(1);
   EXPECT_CALL(*audio_input_listener_,
               Opened(MEDIA_DEVICE_AUDIO_CAPTURE, second_session_id))
       .Times(1);
   // Waits for the callback.
-  base::RunLoop().RunUntilIdle();
+  WaitForOpenCompletion();
 
   manager_->Close(first_session_id);
   manager_->Close(second_session_id);
   EXPECT_CALL(*audio_input_listener_,
               Closed(MEDIA_DEVICE_AUDIO_CAPTURE, first_session_id))
       .Times(1);
   EXPECT_CALL(*audio_input_listener_,
               Closed(MEDIA_DEVICE_AUDIO_CAPTURE, second_session_id))
       .Times(1);
   // Waits for the callback.
@@ skipping 12 matching lines @@
   // Loops through the devices and calls Open()/Close()/GetOpenedDeviceInfoById
   // for each device.
   for (StreamDeviceInfoArray::const_iterator iter = devices_.begin();
        iter != devices_.end(); ++iter, ++index) {
     // Note that no DeviceStopped() notification for Event Handler as we have
     // stopped the device before calling close.
     session_id[index] = manager_->Open(iter->device);
     EXPECT_CALL(*audio_input_listener_,
                 Opened(MEDIA_DEVICE_AUDIO_CAPTURE, session_id[index]))
         .Times(1);
-    base::RunLoop().RunUntilIdle();
+    WaitForOpenCompletion();
 
     const StreamDeviceInfo* info = manager_->GetOpenedDeviceInfoById(
         session_id[index]);
     DCHECK(info);
     EXPECT_EQ(iter->device.id, info->device.id);
     manager_->Close(session_id[index]);
     EXPECT_CALL(*audio_input_listener_,
                 Closed(MEDIA_DEVICE_AUDIO_CAPTURE, session_id[index]))
         .Times(1);
     base::RunLoop().RunUntilIdle();
   }
 }
 
 // Access an invalid session.
 TEST_F(MAYBE_AudioInputDeviceManagerTest, AccessInvalidSession) {
   InSequence s;
 
   // Opens the first device.
   StreamDeviceInfoArray::const_iterator iter = devices_.begin();
   int session_id = manager_->Open(iter->device);
   EXPECT_CALL(*audio_input_listener_,
               Opened(MEDIA_DEVICE_AUDIO_CAPTURE, session_id))
       .Times(1);
-  base::RunLoop().RunUntilIdle();
+  WaitForOpenCompletion();
 
   // Access a non-opened device.
   // This should fail and return an empty StreamDeviceInfo.
   int invalid_session_id = session_id + 1;
   const StreamDeviceInfo* info =
       manager_->GetOpenedDeviceInfoById(invalid_session_id);
   DCHECK(!info);
 
   manager_->Close(session_id);
   EXPECT_CALL(*audio_input_listener_,
               Closed(MEDIA_DEVICE_AUDIO_CAPTURE, session_id))
       .Times(1);
   base::RunLoop().RunUntilIdle();
 }
 
+// No crash during shutdown while Open() is in progress (i.e there are tasks
+// queued on audio thread).
+TEST_F(MAYBE_AudioInputDeviceManagerTest, NoCrashOnShutdown) {
+  // Loops through the devices and calls Open() for each device.
+  for (StreamDeviceInfoArray::const_iterator iter = devices_.begin();
+       iter != devices_.end(); ++iter) {
+    manager_->Open(iter->device);
+  }
+}
+
 }  // namespace content