third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-host-partial-wildcard-allowed.sub.html - Issue 2763253002: Fixed external wpt csp img-src/* tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/content-security-policy/img-src/img-src-host-partial-wildcard-allowed.sub.html

Issue 2763253002: Fixed external wpt csp img-src/* tests. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta http-equiv="Content-Security-Policy" content="img-src *.0.1:{{ports[http][ 0]}}">

	3 <html>

	4 <head>

	5 <title>img-src works correctly with partial host wildcard.</title>

	6 <script src='/resources/testharness.js'></script>

	7 <script src='/resources/testharnessreport.js'></script>

	8 </head>

	9 <body>

	10 <div id='log'/>

	11

	12 <script>

	13 var t1 = async_test("img src matches correctly partial wildcard host csp d irective");

	14 </script>

	15 <img src='http://127.0.0.1:{{ports[http][0]}}/content-security-policy/suppor t/pass.png'
	Mike West 2017/03/22 11:56:22 I'd suggest `.{{host}}` and `{{domains[www]}}` in I'd suggest `.{{host}}` and `{{domains[www]}}` instead of `.0.1` and `127.0.0.1`. Honestly, if those pass in Chrome, then it seems like it has to be a bug in our implementation. Wildcarding IP addresses makes no sense. andypaicu* 2017/03/23 09:22:10 done Show quoted text On 2017/03/22 at 11:56:22, Mike West wrote: > I'd suggest `.{{host}}` and `{{domains[www]}}` instead of `.0.1` and `127.0.0.1`. Honestly, if those pass in Chrome, then it seems like it has to be a bug in our implementation. Wildcarding IP addresses makes no sense. done
	16 onload='t1.done();'

	17 onerror='t1.step(function() { assert_unreached("Image should have loade d"); t1.done(); });'>

	18

	19 </body>

	20 </html>

OLD	NEW