ios/chrome/browser/ui/reading_list/BUILD.gn - Issue 2763233003: Move ReadingList model to components/reading_list/core

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/reading_list/BUILD.gn

Issue 2763233003: Move ReadingList model to components/reading_list/core (Closed)

Patch Set: feedback Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/ntp/BUILD.gn ('k') | ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/reading_list/BUILD.gn

diff --git a/ios/chrome/browser/ui/reading_list/BUILD.gn b/ios/chrome/browser/ui/reading_list/BUILD.gn

index fd7fe3b9f2d0f6e4338855c2ba32338a3762e5fb..62716db17806e07a331b41d3958c7583321f7bc8 100644

--- a/ios/chrome/browser/ui/reading_list/BUILD.gn

+++ b/ios/chrome/browser/ui/reading_list/BUILD.gn

@@ -59,6 +59,8 @@ source_set("reading_list") {

"//base",

"//components/prefs",

"//components/reading_list/core",

+ "//components/reading_list/core:flags",

+ "//components/reading_list/ios",

"//components/strings",

"//components/url_formatter",

"//ios/chrome/app/strings",

@@ -87,7 +89,6 @@ source_set("reading_list") {

"//url",

]

public_deps = [

- "//components/reading_list/ios",

"//ios/chrome/browser/ui/collection_view",

]

allow_circular_includes_from = [ "//ios/chrome/browser/ui/side_swipe" ]

@@ -107,7 +108,7 @@ source_set("unit_tests") {

"//components/favicon/core",

"//components/favicon/core/test:test_support",

"//components/prefs",

- "//components/reading_list/ios",

+ "//components/reading_list/core",

"//components/url_formatter",

"//ios/chrome/browser/browser_state:test_support",

"//ios/chrome/browser/favicon",

@@ -132,7 +133,7 @@ source_set("eg_tests") {

deps = [

":reading_list",

"//base",

- "//components/reading_list/ios",

+ "//components/reading_list/core",

"//ios/chrome/app/strings",

"//ios/chrome/app/theme:theme_grit",

"//ios/chrome/browser/reading_list",