ios/chrome/browser/share_extension/share_extension_service.mm - Issue 2763233003: Move ReadingList model to components/reading_list/core

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/share_extension/share_extension_service.mm

Issue 2763233003: Move ReadingList model to components/reading_list/core (Closed)

Patch Set: last? Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/reading_list/ios/reading_list_model_bridge_observer.h ('K') | « ios/chrome/browser/share_extension/share_extension_service.h ('k') | ios/chrome/browser/sync/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "ios/chrome/browser/share_extension/share_extension_service.h"

5 #include "base/mac/scoped_nsobject.h"	6 #include "base/mac/scoped_nsobject.h"
	sdefresne 2017/03/23 10:57:06 Please add a blank line before #include "base/mac/ Please add a blank line before #include "base/mac/scoped_nsobject.h". Olivier 2017/03/23 12:27:37 Done. Show quoted text On 2017/03/23 10:57:06, sdefresne wrote: > Please add a blank line before #include "base/mac/scoped_nsobject.h". Done.
6 #include "components/bookmarks/browser/bookmark_model.h"	7 #include "components/bookmarks/browser/bookmark_model.h"

7 #include "components/reading_list/ios/reading_list_model.h"	8 #include "components/reading_list/core/reading_list_model.h"

8 #include "ios/chrome/browser/share_extension/share_extension_item_receiver.h"	9 #include "ios/chrome/browser/share_extension/share_extension_item_receiver.h"

9 #include "ios/chrome/browser/share_extension/share_extension_service.h"

10	10

11 #if !defined(__has_feature) \|\| !__has_feature(objc_arc)	11 #if !defined(__has_feature) \|\| !__has_feature(objc_arc)

12 #error "This file requires ARC support."	12 #error "This file requires ARC support."

13 #endif	13 #endif

14	14

15 ShareExtensionService::ShareExtensionService(	15 ShareExtensionService::ShareExtensionService(

16 bookmarks::BookmarkModel* bookmark_model,	16 bookmarks::BookmarkModel* bookmark_model,

17 ReadingListModel* reading_list_model)	17 ReadingListModel* reading_list_model)

18 : reading_list_model_(reading_list_model),	18 : reading_list_model_(reading_list_model),

19 reading_list_model_loaded_(false),	19 reading_list_model_loaded_(false),

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 this->AnyModelLoaded();	54 this->AnyModelLoaded();

55 }	55 }

56	56

57 void ShareExtensionService::AnyModelLoaded() {	57 void ShareExtensionService::AnyModelLoaded() {

58 if (reading_list_model_loaded_ && bookmark_model_loaded_) {	58 if (reading_list_model_loaded_ && bookmark_model_loaded_) {

59 [[ShareExtensionItemReceiver sharedInstance]	59 [[ShareExtensionItemReceiver sharedInstance]

60 setBookmarkModel:bookmark_model_	60 setBookmarkModel:bookmark_model_

61 readingListModel:reading_list_model_];	61 readingListModel:reading_list_model_];

62 }	62 }

63 }	63 }

OLD	NEW