Reland of cc: Don't use StreamVideoDrawQuad on any platform but Android.

cc/resources/video_resource_updater.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/resources/video_resource_updater.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 27 matching lines @@
   switch (video_frame->format()) {
     case media::PIXEL_FORMAT_ARGB:
     case media::PIXEL_FORMAT_XRGB:
     case media::PIXEL_FORMAT_UYVY:
       switch (video_frame->mailbox_holder(0).texture_target) {
         case GL_TEXTURE_2D:
           return (video_frame->format() == media::PIXEL_FORMAT_XRGB)
                      ? VideoFrameExternalResources::RGB_RESOURCE
                      : VideoFrameExternalResources::RGBA_PREMULTIPLIED_RESOURCE;
         case GL_TEXTURE_EXTERNAL_OES:
-          return video_frame->metadata()->IsTrue(
-                     media::VideoFrameMetadata::COPY_REQUIRED)
-                     ? VideoFrameExternalResources::RGBA_RESOURCE
-                     : VideoFrameExternalResources::STREAM_TEXTURE_RESOURCE;
+#if defined(OS_ANDROID)

[danakj, 2017/03/22 14:44:23]

Please don't write OS defines inside cc. They make unit tests become platform
specific. If you need a platform setting use LayerTreeSettings.

[danakj, 2017/03/22 14:47:04]

Oh, this isn't in the layer tree really. Maybe here a constructor parameter to
the VideoResourceUpdater can tell it if stream resources are to be used or not.
Then unit tests can set that or not and verify behaviour.

+          if (!video_frame->metadata()->IsTrue(
+                  media::VideoFrameMetadata::COPY_REQUIRED))
+            return VideoFrameExternalResources::STREAM_TEXTURE_RESOURCE;
+#endif
+          return VideoFrameExternalResources::RGBA_RESOURCE;
         case GL_TEXTURE_RECTANGLE_ARB:
           return VideoFrameExternalResources::RGB_RESOURCE;
         default:
           NOTREACHED();
           break;
       }
       break;
     case media::PIXEL_FORMAT_I420:
       return VideoFrameExternalResources::YUV_RESOURCE;
       break;
@@ skipping 714 matching lines @@
   if (lost_resource) {
     resource_it->clear_refs();
     updater->DeleteResource(resource_it);
     return;
   }
 
   resource_it->remove_ref();
 }
 
 }  // namespace cc