Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2763173002: Form submission with blank target is broken. (Closed)
Patch Set: Revert userClickedRecently change. Remove registerLoadRequest call. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index bcc7afbd77b985b35613968e319d9c9ead935241..0b97c48cf2dd540d296852ce963998b8717cf60f 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -2558,17 +2558,6 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
DLOG(WARNING) << "JS message parameter not found: href";
return NO;
}
- const GURL targetURL(href);
- const GURL currentURL([self currentURL]);
- bool targetsFrame = false;
- message->GetBoolean("targetsFrame", &targetsFrame);
Eugene But (OOO till 7-30) 2017/03/28 18:47:42 Do we also need to remove targetsFrame from JavaSc
michaeldo 2017/03/29 22:53:37 Good call, I removed it and updated description. P
- if (!targetsFrame && web::UrlHasWebScheme(targetURL)) {
- // The referrer is not known yet, and will be updated later.
- const web::Referrer emptyReferrer;
- [self registerLoadRequest:targetURL
- referrer:emptyReferrer
- transition:ui::PAGE_TRANSITION_FORM_SUBMIT];
- }
std::string formName;
message->GetString("formName", &formName);
base::scoped_nsobject<NSSet> observers([_observers copy]);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698