components/omnibox/browser/autocomplete_controller.h - Issue 2763063002: [omnibox] Narrow condition for resetting selection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_controller.h

Issue 2763063002: [omnibox] Narrow condition for resetting selection (Closed)

Patch Set: Removed check, added todo Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/autocomplete_controller.h

diff --git a/components/omnibox/browser/autocomplete_controller.h b/components/omnibox/browser/autocomplete_controller.h

index c35072a654e8057ec7605f66aac398dba1484d13..759340529a3577954006cc27610982b8f475526d 100644

--- a/components/omnibox/browser/autocomplete_controller.h

+++ b/components/omnibox/browser/autocomplete_controller.h

@@ -142,6 +142,7 @@ class AutocompleteController : public AutocompleteProviderListener {

FRIEND_TEST_ALL_PREFIXES(AutocompleteProviderTest, UpdateAssistedQueryStats);

FRIEND_TEST_ALL_PREFIXES(OmniboxViewTest, DoesNotUpdateAutocompleteOnBlur);

FRIEND_TEST_ALL_PREFIXES(OmniboxViewViewsTest, CloseOmniboxPopupOnTextDrag);

+ FRIEND_TEST_ALL_PREFIXES(OmniboxViewViewsTest, MaintainCursorAfterFocusCycle);

// Updates |result_| to reflect the current provider state and fires

// notifications. If |regenerate_result| then we clear the result