Fix incorrect bounding box position for '\n'

third_party/WebKit/Source/core/layout/LayoutText.cpp

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Andrew Wellington (proton@wiretapped.net)
  * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 359 matching lines @@
   // coordinates are unsigneds, so changing this function to take ints causes
   // various internal mismatches. But selectionRect takes ints, and passing
   // UINT_MAX to it causes trouble. Ideally we'd change selectionRect to take
   // unsigneds, but that would cause many ripple effects, so for now we'll just
   // clamp our unsigned parameters to INT_MAX.
   ASSERT(end == UINT_MAX || end <= INT_MAX);
   ASSERT(start <= INT_MAX);
   start = std::min(start, static_cast<unsigned>(INT_MAX));
   end = std::min(end, static_cast<unsigned>(INT_MAX));
 
+  bool hasCheckedBoxInRange = false;
+
   for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
     // Note: box->end() returns the index of the last character, not the index
     // past it
     if (start <= box->start() && box->end() < end) {
       FloatRect r(box->frameRect());
       if (useSelectionHeight) {
         LayoutRect selectionRect = box->localSelectionRect(start, end);
         if (box->isHorizontal()) {
           r.setHeight(selectionRect.height().toFloat());
           r.setY(selectionRect.y().toFloat());
         } else {
           r.setWidth(selectionRect.width().toFloat());
           r.setX(selectionRect.x().toFloat());
         }
       }
+      if (!hasCheckedBoxInRange) {
+        hasCheckedBoxInRange = true;
+        rects.clear();
+      }
       rects.push_back(localToAbsoluteQuad(r).enclosingBoundingBox());
-    } else {
+    } else if ((box->start() <= start && start <= box->end()) ||
+               (box->start() < end && end <= box->end())) {
+      FloatRect rect = localQuadForTextBox(box, start, end, useSelectionHeight);
+      if (!rect.isZero()) {
+        if (!hasCheckedBoxInRange) {
+          hasCheckedBoxInRange = true;
+          rects.clear();
+        }
+        rects.push_back(localToAbsoluteQuad(rect).enclosingBoundingBox());
+      }
+    } else if (!hasCheckedBoxInRange) {
       // FIXME: This code is wrong. It's converting local to absolute twice.
       // http://webkit.org/b/65722
       FloatRect rect = localQuadForTextBox(box, start, end, useSelectionHeight);
       if (!rect.isZero())
         rects.push_back(localToAbsoluteQuad(rect).enclosingBoundingBox());
     }
   }
 }
 
 static IntRect ellipsisRectForBox(InlineTextBox* box,
@@ skipping 70 matching lines @@
   end = std::min(end, static_cast<unsigned>(INT_MAX));
 
   const unsigned caretMinOffset = static_cast<unsigned>(this->caretMinOffset());
   const unsigned caretMaxOffset = static_cast<unsigned>(this->caretMaxOffset());
 
   // Narrows |start| and |end| into |caretMinOffset| and |careMaxOffset|
   // to ignore unrendered leading and trailing whitespaces.
   start = std::min(std::max(caretMinOffset, start), caretMaxOffset);
   end = std::min(std::max(caretMinOffset, end), caretMaxOffset);
 
+  bool hasCheckedBoxInRange = false;
+
   for (InlineTextBox* box = firstTextBox(); box; box = box->nextTextBox()) {
     // Note: box->end() returns the index of the last character, not the index
     // past it
     if (start <= box->start() && box->end() < end) {
       LayoutRect r(box->frameRect());
       if (useSelectionHeight) {
         LayoutRect selectionRect = box->localSelectionRect(start, end);
         if (box->isHorizontal()) {
           r.setHeight(selectionRect.height());
           r.setY(selectionRect.y());
         } else {
           r.setWidth(selectionRect.width());
           r.setX(selectionRect.x());
         }
       }
+      if (!hasCheckedBoxInRange) {
+        hasCheckedBoxInRange = true;
+        quads.clear();
+      }
       quads.push_back(localToAbsoluteQuad(FloatRect(r)));
-    } else {
+    } else if ((box->start() <= start && start <= box->end()) ||
+               (box->start() < end && end <= box->end())) {
+      FloatRect rect = localQuadForTextBox(box, start, end, useSelectionHeight);
+      if (!rect.isZero()) {
+        if (!hasCheckedBoxInRange) {
+          hasCheckedBoxInRange = true;
+          quads.clear();
+        }
+        quads.push_back(localToAbsoluteQuad(rect));
+      }
+    } else if (!hasCheckedBoxInRange) {
+      // consider when the offset of range is area of leading or trailing
+      // whitespace
       FloatRect rect = localQuadForTextBox(box, start, end, useSelectionHeight);
       if (!rect.isZero())
-        quads.push_back(localToAbsoluteQuad(rect));
+        quads.push_back(localToAbsoluteQuad(rect).enclosingBoundingBox());
     }
   }
 }
 
 FloatRect LayoutText::localBoundingBoxRectForAccessibility() const {
   FloatRect result;
   Vector<FloatQuad> quads;
   this->quads(quads, LayoutText::ClipToEllipsis, LayoutText::LocalQuads);
   for (const FloatQuad& quad : quads)
     result.unite(quad.boundingBox());
@@ skipping 1536 matching lines @@
   LayoutRect rect = LayoutRect(
       IntRect(firstRunX(), firstRunY(), linesBox.width(), linesBox.height()));
   LayoutBlock* block = containingBlock();
   if (block && hasTextBoxes())
     block->adjustChildDebugRect(rect);
 
   return rect;
 }
 
 }  // namespace blink