Issue 2763004: Reland r49188

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2763004: Reland r49188 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by willchan no longer on Chromium

Modified:
4 years ago

Reviewers:
hamaji

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Reland r49188. It was reverted due to breaking a valgrind test which has since been disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49320

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+496 lines, -168 lines)			Patch
M	base/message_loop.h	View	9 chunks	+60 lines, -18 lines	0 comments	Download
M	base/message_loop.cc	View	3 chunks	+13 lines, -7 lines	0 comments	Download
M	base/message_loop_unittest.cc	View	6 chunks	+73 lines, -8 lines	0 comments	Download
M	base/message_pump_libevent.h	View	6 chunks	+60 lines, -26 lines	0 comments	Download
M	base/message_pump_libevent.cc	View	7 chunks	+50 lines, -9 lines	0 comments	Download
M	base/message_pump_win.h	View	5 chunks	+24 lines, -1 line	0 comments	Download
M	base/message_pump_win.cc	View	2 chunks	+19 lines, -1 line	0 comments	Download
M	base/tracked.h	View	2 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/jankometer.cc	View	3 chunks	+189 lines, -96 lines	0 comments	Download

Trybot results:

Total messages: 1 (0 generated)

TBR