Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2762953003: More minor type improvements in dart:async. (Closed)

Created:
3 years, 9 months ago by floitsch
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -128 lines) Patch
M sdk/lib/async/async_error.dart View 1 1 chunk +4 lines, -26 lines 0 comments Download
M sdk/lib/async/broadcast_stream_controller.dart View 1 1 chunk +0 lines, -28 lines 0 comments Download
M sdk/lib/async/future.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 1 12 chunks +21 lines, -27 lines 0 comments Download
M sdk/lib/async/stream.dart View 1 6 chunks +8 lines, -7 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 1 chunk +3 lines, -5 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 1 3 chunks +6 lines, -5 lines 0 comments Download
M sdk/lib/async/stream_pipe.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/async/stream_transformers.dart View 1 3 chunks +15 lines, -22 lines 0 comments Download
M sdk/lib/async/zone.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
floitsch
3 years, 9 months ago (2017-03-21 19:01:53 UTC) #2
floitsch
Just in case: I'm finding more places. Please wait with reviewing.
3 years, 9 months ago (2017-03-21 20:10:54 UTC) #3
floitsch
Ready for review now.
3 years, 9 months ago (2017-03-21 20:47:43 UTC) #5
floitsch
+Bob, since Lasse is on vacation.
3 years, 9 months ago (2017-03-21 20:48:04 UTC) #7
Bob Nystrom
LGTM!
3 years, 9 months ago (2017-03-21 21:14:55 UTC) #8
floitsch
3 years, 9 months ago (2017-03-22 16:24:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0e541c1eacb5aa78d96330168fc99fa6a2ffceca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698