Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 276293002: Add sashab@ as an owner of the app_info_dialog directory (Closed)

Created:
6 years, 7 months ago by sashab
Modified:
6 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Add sashab@ as an owner of the app_info_dialog directory Add sashab@ to the OWNERS file in the views/apps/app_info_dialog directory. Committed: https://crrev.com/ba52e3a7f6b1942adea92f422901bc4c68f7c934 Cr-Commit-Position: refs/heads/master@{#302410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A chrome/browser/ui/views/apps/app_info_dialog/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
sashab
6 years, 7 months ago (2014-05-12 01:21:07 UTC) #1
tfarina
Just curious, are you a full committer already?
6 years, 7 months ago (2014-05-12 05:06:35 UTC) #2
sashab
On 2014/05/12 05:06:35, tfarina wrote: > Just curious, are you a full committer already? No, ...
6 years, 7 months ago (2014-05-12 05:14:12 UTC) #3
sashab
Should we re-try this now that I'm a full committer? :)
6 years, 5 months ago (2014-07-02 00:33:11 UTC) #4
benwells
On 2014/07/02 00:33:11, sasha_b wrote: > Should we re-try this now that I'm a full ...
6 years, 5 months ago (2014-07-02 00:35:13 UTC) #5
sashab
Re-visit :-)
6 years, 1 month ago (2014-11-03 00:15:19 UTC) #6
benwells
lgtm
6 years, 1 month ago (2014-11-03 02:22:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/276293002/1
6 years, 1 month ago (2014-11-03 02:23:55 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 03:04:28 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 03:05:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba52e3a7f6b1942adea92f422901bc4c68f7c934
Cr-Commit-Position: refs/heads/master@{#302410}

Powered by Google App Engine
This is Rietveld 408576698