Issue 28580. Relax instantiate to bounds.

Issue 28580. Relax instantiate to bounds.

This feature works only with the new analysis driver, because it is
implemented only in summaries linker.

R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/28580

Committed: https://github.com/dart-lang/sdk/commit/ef527a9bdef02534817fcb2cada5b3d4cef34c97

[Leaf, 2017-03-21 04:58:42]

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/type.dart (right):

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/type.dart:2497: return true;
This should only return true for other type parameters from the same scope, not
from outer scopes.  So:

class C<T> {
  S f<S extends List<T>>() {}
  void test() {
    var x = f(); // Not an error, x should have type List<T>
  }
}

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/type.dart:2500: } else {
Are the new function types instances of ParameterizedType or does this need to
account for that?

[scheglov, 2017-03-21 05:42:00]

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/type.dart (right):

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/type.dart:2497: return true;
On 2017/03/21 04:58:42, Leaf wrote:
> This should only return true for other type parameters from the same scope,
not
> from outer scopes.  So:
> 
> class C<T> {
>   S f<S extends List<T>>() {}
>   void test() {
>     var x = f(); // Not an error, x should have type List<T>
>   }
> }  

I'm sorry, I must have missed something in the specification, or may be don't
know which specification to read.


The CL is about relaxing rules for type annotations in bounds or type
parameters.
https://github.com/dart-lang/sdk/issues/28580

Do you talk about instantiate to bounds here?
I just don't understand what you mean when give an example with a method
invocation.


I always thought only about type annotations referencing classes and function
type aliases. Are the same rules also applied to function types of method
invocations?

So, do you mean that f() invocation should have an error in this case?

class C<T> {
  S f<K, S extends List<K>>() => null;
  void test() {
    var x = f();
  }
}

Or List<K> in f() declaration?
Or we don't want to put errors in declarations because we might be able to infer
type arguments?

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/type.dart:2500: } else {
On 2017/03/21 04:58:42, Leaf wrote:
> Are the new function types instances of ParameterizedType or does this need to
> account for that?

AFAIK these are also FunctionType(s), so ParameterizedType(s).

[Leaf, 2017-03-21 13:24:54]

lgtm

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/type.dart (right):

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/type.dart:2497: return true;
On 2017/03/21 05:42:00, scheglov wrote:
> On 2017/03/21 04:58:42, Leaf wrote:
> > This should only return true for other type parameters from the same scope,
> not
> > from outer scopes.  So:
> > 
> > class C<T> {
> >   S f<S extends List<T>>() {}
> >   void test() {
> >     var x = f(); // Not an error, x should have type List<T>
> >   }
> > }  
> 
> I'm sorry, I must have missed something in the specification, or may be don't
> know which specification to read.
> 
> 
> The CL is about relaxing rules for type annotations in bounds or type
> parameters.
> https://github.com/dart-lang/sdk/issues/28580
> 
> Do you talk about instantiate to bounds here?
> I just don't understand what you mean when give an example with a method
> invocation.
> 
> 
> I always thought only about type annotations referencing classes and function
> type aliases. Are the same rules also applied to function types of method
> invocations?
> 
> So, do you mean that f() invocation should have an error in this case?
> 
> class C<T> {
>   S f<K, S extends List<K>>() => null;
>   void test() {
>     var x = f();
>   }
> }
> 
> Or List<K> in f() declaration?
> Or we don't want to put errors in declarations because we might be able to
infer
> type arguments?

Ignore everything I said, I was thinking about something else entirely.  You're
completely correct, this isn't relevant here, since this only has to do with
types in bounds, and classes can't be nested.

[Brian Wilkerson, 2017-03-21 13:39:56]

lgtm

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/element_text.dart (right):

https://codereview.chromium.org/2762863002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/element_text.dart:112: if (actualText != expected)
{
Did you intend to leave this debugging code uncommented?

[scheglov, 2017-03-21 15:56:34]

Description was changed from

==========
Issue 28580. Relax instantiate to bounds.

This feature works only with the new analysis driver, because it is
implemented only in summaries linker.

R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/28580
==========

to

==========
Issue 28580. Relax instantiate to bounds.

This feature works only with the new analysis driver, because it is
implemented only in summaries linker.

R=brianwilkerson@google.com, leafp@google.com
BUG= https://github.com/dart-lang/sdk/issues/28580

Committed:
https://github.com/dart-lang/sdk/commit/ef527a9bdef02534817fcb2cada5b3d4cef34c97
==========

[scheglov, 2017-03-21 15:56:35]

Committed patchset #1 (id:1) manually as
ef527a9bdef02534817fcb2cada5b3d4cef34c97 (presubmit successful).