gpu: Use decoder state restoration for scoped_binders

gpu/command_buffer/service/context_state.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/context_state.h"
 
 #include <stddef.h>
 
 #include <cmath>
 
@@ skipping 399 matching lines @@
           glVertexAttribI4uiv(attrib, v);
         }
         break;
       default:
         NOTREACHED();
         break;
     }
   }
 }
 
+void ContextState::RestoreVertexAttribArray(unsigned attrib_index) const {
+  const VertexAttrib* attrib =
+      vertex_attrib_manager->GetVertexAttrib(attrib_index);
+
+  // Restore vertex array.
+  Buffer* buffer = attrib->buffer();
+  GLuint buffer_service_id = buffer ? buffer->service_id() : 0;
+  glBindBuffer(GL_ARRAY_BUFFER, buffer_service_id);
+  const void* ptr = reinterpret_cast<const void*>(attrib->offset());
+  glVertexAttribPointer(attrib_index, attrib->size(), attrib->type(),
+                        attrib->normalized(), attrib->gl_stride(), ptr);
+
+  // Restore attrib divisor if supported.
+  if (feature_info_->feature_flags().angle_instanced_arrays)
+    glVertexAttribDivisorANGLE(attrib_index, attrib->divisor());
+
+  // Never touch vertex attribute 0's state (in particular, never
+  // disable it) when running on desktop GL with compatibility profile
+  // because it will never be re-enabled.
+  if (attrib_index != 0 || feature_info_->gl_version_info().BehavesLikeGLES()) {
+    if (attrib->enabled()) {
+      glEnableVertexAttribArray(attrib_index);
+    } else {
+      glDisableVertexAttribArray(attrib_index);
+    }
+  }
+}
+
 void ContextState::RestoreVertexAttribArrays(
     const scoped_refptr<VertexAttribManager> attrib_manager) const {
   // This is expected to be called only for VAO with service_id 0,
   // either to restore the default VAO or a virtual VAO with service_id 0.
   GLuint vao_service_id = attrib_manager->service_id();
   DCHECK(vao_service_id == 0);
 
   // Bind VAO if supported.
   if (feature_info_->feature_flags().native_vertex_array_object)
     glBindVertexArrayOES(vao_service_id);
 
   // Restore vertex attrib arrays.
   for (size_t attrib_index = 0; attrib_index < attrib_manager->num_attribs();
-       ++attrib_index) {
-    const VertexAttrib* attrib = attrib_manager->GetVertexAttrib(attrib_index);
-
-    // Restore vertex array.
-    Buffer* buffer = attrib->buffer();
-    GLuint buffer_service_id = buffer ? buffer->service_id() : 0;
-    glBindBuffer(GL_ARRAY_BUFFER, buffer_service_id);
-    const void* ptr = reinterpret_cast<const void*>(attrib->offset());
-    glVertexAttribPointer(attrib_index,
-                          attrib->size(),
-                          attrib->type(),
-                          attrib->normalized(),
-                          attrib->gl_stride(),
-                          ptr);
-
-    // Restore attrib divisor if supported.
-    if (feature_info_->feature_flags().angle_instanced_arrays)
-      glVertexAttribDivisorANGLE(attrib_index, attrib->divisor());
-
-    // Never touch vertex attribute 0's state (in particular, never
-    // disable it) when running on desktop GL with compatibility profile
-    // because it will never be re-enabled.
-    if (attrib_index != 0 ||
-        feature_info_->gl_version_info().BehavesLikeGLES()) {
-      if (attrib->enabled()) {
-        glEnableVertexAttribArray(attrib_index);
-      } else {
-        glDisableVertexAttribArray(attrib_index);
-      }
-    }
-  }
+       ++attrib_index)
+    RestoreVertexAttribArray(attrib_index);

[piman, 2017/03/22 21:28:26]

This needs to pass in |attrib_manager|. RestoreVertexAttribArrays can be called
with either |vertex_attrib_manager| or |default_vertex_attrib_manager|, so we
can't assume it's the former.

[Chandan, 2017/03/23 09:19:39]

Have removed these changes in context_state.cc in patchset 2.

 }
 
 void ContextState::RestoreVertexAttribs() const {
   // Restore Vertex Attrib Arrays
   DCHECK(vertex_attrib_manager.get());
   // Restore VAOs.
   if (feature_info_->feature_flags().native_vertex_array_object) {
     // If default VAO is still using shared id 0 instead of unique ids
     // per-context, default VAO state must be restored.
     GLuint default_vao_service_id =
@@ skipping 239 matching lines @@
   UpdateUnpackParameters();
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "gpu/command_buffer/service/context_state_impl_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu