Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issue 2762743002: Include type arguments for non-synthetic FunctionTypeImpl(s) into displayName. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include type arguments for non-synthetic FunctionTypeImpl(s) into displayName. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/82751915c1655f882b8ec67b538b0372b41b0202

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -5 lines) Patch
M pkg/analyzer/lib/src/dart/element/type.dart View 1 chunk +30 lines, -2 lines 1 comment Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-20 20:06:20 UTC) #1
Brian Wilkerson
I'm not sure what the effect of this will be on the UI for either ...
3 years, 9 months ago (2017-03-20 20:13:47 UTC) #2
scheglov
3 years, 9 months ago (2017-03-20 20:18:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
82751915c1655f882b8ec67b538b0372b41b0202 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698