Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: src/profile-generator-inl.h

Issue 27627006: Always make a copy of a string when adding it to StringsStorage (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Added empty line Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/profile-generator.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 15 matching lines...) Expand all
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 #ifndef V8_PROFILE_GENERATOR_INL_H_ 28 #ifndef V8_PROFILE_GENERATOR_INL_H_
29 #define V8_PROFILE_GENERATOR_INL_H_ 29 #define V8_PROFILE_GENERATOR_INL_H_
30 30
31 #include "profile-generator.h" 31 #include "profile-generator.h"
32 32
33 namespace v8 { 33 namespace v8 {
34 namespace internal { 34 namespace internal {
35 35
36 const char* StringsStorage::GetFunctionName(Name* name) {
37 return GetFunctionName(GetName(name));
38 }
39
40
41 const char* StringsStorage::GetFunctionName(const char* name) {
42 return strlen(name) > 0 ? name : ProfileGenerator::kAnonymousFunctionName;
43 }
44
45
46 CodeEntry::CodeEntry(Logger::LogEventsAndTags tag, 36 CodeEntry::CodeEntry(Logger::LogEventsAndTags tag,
47 const char* name, 37 const char* name,
48 const char* name_prefix, 38 const char* name_prefix,
49 const char* resource_name, 39 const char* resource_name,
50 int line_number, 40 int line_number,
51 int column_number) 41 int column_number)
52 : tag_(tag), 42 : tag_(tag),
53 builtin_id_(Builtins::builtin_count), 43 builtin_id_(Builtins::builtin_count),
54 name_prefix_(name_prefix), 44 name_prefix_(name_prefix),
55 name_(name), 45 name_(name),
(...skipping 19 matching lines...) Expand all
75 ProfileNode::ProfileNode(ProfileTree* tree, CodeEntry* entry) 65 ProfileNode::ProfileNode(ProfileTree* tree, CodeEntry* entry)
76 : tree_(tree), 66 : tree_(tree),
77 entry_(entry), 67 entry_(entry),
78 self_ticks_(0), 68 self_ticks_(0),
79 children_(CodeEntriesMatch), 69 children_(CodeEntriesMatch),
80 id_(tree->next_node_id()) { } 70 id_(tree->next_node_id()) { }
81 71
82 } } // namespace v8::internal 72 } } // namespace v8::internal
83 73
84 #endif // V8_PROFILE_GENERATOR_INL_H_ 74 #endif // V8_PROFILE_GENERATOR_INL_H_
OLDNEW
« no previous file with comments | « src/profile-generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698