Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: content/browser/background_fetch/background_fetch_service_impl.cc

Issue 2762663002: BackgroundFetchRegistration.abort() should return a Promise. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_service_impl.cc
diff --git a/content/browser/background_fetch/background_fetch_service_impl.cc b/content/browser/background_fetch/background_fetch_service_impl.cc
index cb81edcaec3b54a7a3f1b5c15cf2f02796eb9a78..d9238374d0fdfe5fd81c54aa0dd9e4c3372917a6 100644
--- a/content/browser/background_fetch/background_fetch_service_impl.cc
+++ b/content/browser/background_fetch/background_fetch_service_impl.cc
@@ -50,11 +50,14 @@ void BackgroundFetchServiceImpl::UpdateUI(
}
void BackgroundFetchServiceImpl::Abort(int64_t service_worker_registration_id,
- const std::string& tag) {
+ const std::string& tag,
+ const AbortCallback& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
// TODO(peter): Get the BackgroundFetchJobController for the
// {service_worker_registration_id, tag} pair and call Abort() on it.
+
+ callback.Run(blink::mojom::BackgroundFetchError::NONE);
}
void BackgroundFetchServiceImpl::GetRegistration(

Powered by Google App Engine
This is Rietveld 408576698