third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp - Issue 2762643004: Separate zeroing pixel data from setting alpha

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp

Issue 2762643004: Separate zeroing pixel data from setting alpha (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp

index 734a7b2527bed95be6dc11f960bf2a1024f337ac..303b99844f526be20b997e1e3a734edd12720c31 100644

--- a/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp

@@ -824,6 +824,7 @@ BMPImageReader::ProcessingResult BMPImageReader::processNonRLEData(

m_seenNonZeroAlphaPixel = true;

if (m_seenZeroAlphaPixel) {

m_buffer->zeroFillPixelData();

+ m_buffer->setHasAlpha(true);

m_seenZeroAlphaPixel = false;

} else if (alpha != 255)

m_buffer->setHasAlpha(true);

« third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp ('k') | no next file » | no next file with comments »