Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: ui/aura/client/window_parenting_client.h

Issue 2762633003: Remove unused |context| from GetDefaultParent(). (Closed)
Patch Set: update comments. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_window_parenting_client.cc ('k') | ui/aura/client/window_parenting_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/client/window_parenting_client.h
diff --git a/ui/aura/client/window_parenting_client.h b/ui/aura/client/window_parenting_client.h
index b17930efa7e0b72de4e023aa0823d6977e7be73f..c946a300644849e43cccc694ed9d55eb8acd36e7 100644
--- a/ui/aura/client/window_parenting_client.h
+++ b/ui/aura/client/window_parenting_client.h
@@ -22,17 +22,12 @@ class AURA_EXPORT WindowParentingClient {
virtual ~WindowParentingClient() {}
// Called by the Window when it looks for a default parent. Returns the
- // window that |window| should be added to instead. |context| provides a
- // Window (generally a RootWindow) that can be used to determine which
- // desktop type the default parent should be chosen from. NOTE: this may
- // have side effects. It should only be used when |window| is going to be
+ // window that |window| should be added to instead. NOTE: this may have
+ // side effects. It should only be used when |window| is going to be
// immediately added.
//
- // TODO(erg): Remove |context|, and maybe after oshima's patch lands,
- // |bounds|.
- virtual Window* GetDefaultParent(Window* context,
- Window* window,
- const gfx::Rect& bounds) = 0;
+ // TODO(erg): Maybe after oshima's patch lands, remove |bounds|.
sky 2017/03/20 17:57:34 Remove this comment as bounds is needed.
+ virtual Window* GetDefaultParent(Window* window, const gfx::Rect& bounds) = 0;
};
// Set/Get a window tree client for the RootWindow containing |window|. |window|
« no previous file with comments | « headless/lib/browser/headless_window_parenting_client.cc ('k') | ui/aura/client/window_parenting_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698