Issue 276263003: Convert some third_party deps to GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276263003: Convert some third_party deps to GN (Closed)

Created:
6 years, 7 months ago by brettw

Modified:
6 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Convert some third_party deps to GN These are required by Blink platform which I'm working on now. Also adds a missing enum to the GN target name description function. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269971

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : formatting #

Total comments: 1

Patch Set 4 : review comment, android build #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -0 lines)			Patch
M	BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	third_party/brotli/BUILD.gn	View	1 2 3	1 chunk	+28 lines, -0 lines	0 comments	Download
A	third_party/iccjpeg/BUILD.gn	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
A	third_party/qcms/BUILD.gn	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
A	tools/gn/secondary/third_party/ots/BUILD.gn	View	1	1 chunk	+90 lines, -0 lines	0 comments	Download
M	tools/gn/target.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/276263003/diff/40001/third_party/brotli/BUILD.gn File third_party/brotli/BUILD.gn (right): https://codereview.chromium.org/276263003/diff/40001/third_party/brotli/BUILD.gn#newcode1 third_party/brotli/BUILD.gn:1: # Copyright (c) 2013 The Chromium Authors. All ...

6 years, 7 months ago (2014-05-12 16:54:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/276263003/60001

6 years, 7 months ago (2014-05-12 23:56:48 UTC) #4

Message was sent while issue was closed.

Change committed as 269971

Expand Messages | Collapse Messages