ios/chrome/browser/ui/settings/settings_egtest.mm - Issue 2762623004: Fix SettingsTestCase.test[Metrics|Breakpad]Reporting on Official

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/settings_egtest.mm

Issue 2762623004: Fix SettingsTestCase.test[Metrics|Breakpad]Reporting on Official (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/settings/settings_egtest.mm

diff --git a/ios/chrome/browser/ui/settings/settings_egtest.mm b/ios/chrome/browser/ui/settings/settings_egtest.mm

index 87f28d3b7d47e786a36298e1d9003e8d3686c80b..8bcf82e7d2f54a54967bd05959d7fd4e0f8897e3 100644

--- a/ios/chrome/browser/ui/settings/settings_egtest.mm

+++ b/ios/chrome/browser/ui/settings/settings_egtest.mm

@@ -605,11 +605,7 @@ bool IsCertificateCleared() {

metrics::prefs::kMetricsReportingEnabled, YES);

chrome_test_util::SetBooleanLocalStatePref(prefs::kMetricsReportingWifiOnly,

NO);

- // Service should be always enabled regardless of network settings.

- chrome_test_util::SetWWANStateTo(YES);

[self assertMetricsServiceEnabled:serviceType];

- chrome_test_util::SetWWANStateTo(NO);

- [self assertMetricsServiceDisabled:serviceType];

lpromero 2017/03/20 16:56:56 Note that this was a typo already, as it should ha

#else

// Development build. Do not allow any recording or uploading of data.

// Specifically, the kMetricsReportingEnabled preference is completely

« no previous file with comments | « ios/chrome/app/application_delegate/metrics_mediator.mm ('k') | no next file » | no next file with comments »