Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h

Issue 2762623002: [css-align] Adapt the place-content shorthand to the new baseline syntax (Closed)
Patch Set: Additional refactoring to deal with baseline value ID Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h
diff --git a/third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h b/third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h
index 1f97a13d4ea5be62c4a530faeafbf8d380540b24..7986bc10ac208d4c6ff6c131d385ddf6e3a4d48d 100644
--- a/third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h
+++ b/third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h
@@ -5,6 +5,7 @@
#ifndef CSSPropertyAlignmentUtils_h
#define CSSPropertyAlignmentUtils_h
+#include "core/css/CSSIdentifierValue.h"
#include "wtf/Allocator.h"
namespace blink {
@@ -15,6 +16,14 @@ class CSSValue;
class CSSPropertyAlignmentUtils {
STATIC_ONLY(CSSPropertyAlignmentUtils);
+ static bool isContentDistributionKeyword(CSSValueID);
+ static bool isContentPositionKeyword(CSSValueID);
+ static bool isBaselineKeyword(CSSValueID);
+ static bool isOverflowKeyword(CSSValueID);
Bugs Nash 2017/03/29 02:01:01 this one doesn't need to be made public either way
jfernandez 2017/03/29 10:43:10 Ok.
+ static CSSIdentifierValue* consumeSelfPositionKeyword(CSSParserTokenRange&);
Bugs Nash 2017/03/29 02:01:01 as above
jfernandez 2017/03/29 10:43:10 Ok, but I think we will need it for implementing t
+ static CSSValue* consumeBaselineKeyword(CSSParserTokenRange&);
+ static CSSValueID getBaselineKeyword(CSSValue&);
+
static CSSValue* consumeSelfPositionOverflowPosition(CSSParserTokenRange&);
static CSSValue* consumeContentDistributionOverflowPosition(
CSSParserTokenRange&);

Powered by Google App Engine
This is Rietveld 408576698