third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h - Issue 2762623002: [css-align] Adapt the place-content shorthand to the new baseline syntax

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.h

Issue 2762623002: [css-align] Adapt the place-content shorthand to the new baseline syntax (Closed)

Patch Set: Additional refactoring to deal with baseline value ID Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('K') | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/properties/CSSPropertyAlignmentUtils.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CSSPropertyAlignmentUtils_h	5 #ifndef CSSPropertyAlignmentUtils_h

6 #define CSSPropertyAlignmentUtils_h	6 #define CSSPropertyAlignmentUtils_h

7	7

	8 #include "core/css/CSSIdentifierValue.h"

8 #include "wtf/Allocator.h"	9 #include "wtf/Allocator.h"

9	10

10 namespace blink {	11 namespace blink {

11	12

12 class CSSParserTokenRange;	13 class CSSParserTokenRange;

13 class CSSValue;	14 class CSSValue;

14	15

15 class CSSPropertyAlignmentUtils {	16 class CSSPropertyAlignmentUtils {

16 STATIC_ONLY(CSSPropertyAlignmentUtils);	17 STATIC_ONLY(CSSPropertyAlignmentUtils);

17	18

	19 static bool isContentDistributionKeyword(CSSValueID);

	20 static bool isContentPositionKeyword(CSSValueID);

	21 static bool isBaselineKeyword(CSSValueID);

	22 static bool isOverflowKeyword(CSSValueID);
	Bugs Nash 2017/03/29 02:01:01 this one doesn't need to be made public either way this one doesn't need to be made public either way jfernandez 2017/03/29 10:43:10 Ok. Show quoted text On 2017/03/29 02:01:01, Bugs Nash wrote: > this one doesn't need to be made public either way Ok.
	23 static CSSIdentifierValue* consumeSelfPositionKeyword(CSSParserTokenRange&);
	Bugs Nash 2017/03/29 02:01:01 as above as above jfernandez 2017/03/29 10:43:10 Ok, but I think we will need it for implementing t Show quoted text On 2017/03/29 02:01:01, Bugs Nash wrote: > as above Ok, but I think we will need it for implementing the place-items and place-self shorthand. Anyway, I agree on keeping it as private for now.
	24 static CSSValue* consumeBaselineKeyword(CSSParserTokenRange&);

	25 static CSSValueID getBaselineKeyword(CSSValue&);

	26

18 static CSSValue* consumeSelfPositionOverflowPosition(CSSParserTokenRange&);	27 static CSSValue* consumeSelfPositionOverflowPosition(CSSParserTokenRange&);

19 static CSSValue* consumeContentDistributionOverflowPosition(	28 static CSSValue* consumeContentDistributionOverflowPosition(

20 CSSParserTokenRange&);	29 CSSParserTokenRange&);

21 };	30 };

22	31

23 } // namespace blink	32 } // namespace blink

24	33

25 #endif // CSSPropertyAlignmentUtils_h	34 #endif // CSSPropertyAlignmentUtils_h

OLD	NEW