Add --headless flag to Windows

headless/lib/headless_browser_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/command_line.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_util.h"
 #include "base/memory/ptr_util.h"
@@ skipping 607 matching lines @@
   EXPECT_TRUE(WaitForLoad(web_contents));
 
   // We should have sent the matching cookies this time.
   EXPECT_EQ(1u, sent_cookies.size());
   EXPECT_EQ("shape", sent_cookies[0].Name());
   EXPECT_EQ("oblong", sent_cookies[0].Value());
 }
 
 // TODO(skyostil): This test currently relies on being able to run a shell
 // script.
 #if defined(OS_POSIX)

[Sami, 2017/03/22 19:46:25]

If this doesn't build on Windows, let's just put the whole test inside #ifdef
OS_POSIX and remove the MAYBE_ business.

[dvallet, 2017/03/27 05:59:50]

Done

 #define MAYBE_RendererCommandPrefixTest RendererCommandPrefixTest
-#else
-#define MAYBE_RendererCommandPrefixTest DISABLED_RendererCommandPrefixTest
-#endif  // defined(OS_POSIX)
 IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, MAYBE_RendererCommandPrefixTest) {
   base::ThreadRestrictions::SetIOAllowed(true);
   base::FilePath launcher_stamp;
   base::CreateTemporaryFile(&launcher_stamp);
 
   base::FilePath launcher_script;
   FILE* launcher_file = base::CreateAndOpenTemporaryFile(&launcher_script);
   fprintf(launcher_file, "#!/bin/sh\n");
   fprintf(launcher_file, "echo $@ > %s\n", launcher_stamp.value().c_str());
   fprintf(launcher_file, "exec $@\n");
@@ skipping 18 matching lines @@
   EXPECT_TRUE(WaitForLoad(web_contents));
 
   // Make sure the launcher was invoked when starting the renderer.
   std::string stamp;
   EXPECT_TRUE(base::ReadFileToString(launcher_stamp, &stamp));
   EXPECT_GE(stamp.find("--type=renderer"), 0u);
 
   base::DeleteFile(launcher_script, false);
   base::DeleteFile(launcher_stamp, false);
 }
-
+#else
+#define MAYBE_RendererCommandPrefixTest DISABLED_RendererCommandPrefixTest
+#endif  // defined(OS_POSIX)
 class CrashReporterTest : public HeadlessBrowserTest,
                           public HeadlessWebContents::Observer,
                           inspector::ExperimentalObserver {
  public:
   CrashReporterTest() : devtools_client_(HeadlessDevToolsClient::Create()) {}
   ~CrashReporterTest() override {}
 
   void SetUp() override {
     base::ThreadRestrictions::SetIOAllowed(true);
-    base::CreateNewTempDirectory("CrashReporterTest", &crash_dumps_dir_);
+    base::CreateNewTempDirectory(FILE_PATH_LITERAL("CrashReporterTest"),
+                                 &crash_dumps_dir_);
     EXPECT_FALSE(options()->enable_crash_reporter);
     options()->enable_crash_reporter = true;
     options()->crash_dumps_dir = crash_dumps_dir_;
     HeadlessBrowserTest::SetUp();
   }
 
   void TearDown() override {
     base::ThreadRestrictions::SetIOAllowed(true);
     base::DeleteFile(crash_dumps_dir_, /* recursive */ false);
   }
@@ skipping 42 matching lines @@
   // The target has crashed and should no longer be there.
   EXPECT_FALSE(web_contents_->GetDevToolsTarget());
 
   // Check that one minidump got created.
   {
     base::ThreadRestrictions::SetIOAllowed(true);
     base::FileEnumerator it(crash_dumps_dir_, /* recursive */ false,
                             base::FileEnumerator::FILES);
     base::FilePath minidump = it.Next();
     EXPECT_FALSE(minidump.empty());
-    EXPECT_EQ(".dmp", minidump.Extension());
+    EXPECT_EQ(FILE_PATH_LITERAL(".dmp"), minidump.Extension());
     EXPECT_TRUE(it.Next().empty());
   }
 
   web_contents_->RemoveObserver(this);
   web_contents_->Close();
   web_contents_ = nullptr;
 
   browser_context_->Close();
   browser_context_ = nullptr;
 }
 
 }  // namespace headless