Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: content/browser/background_fetch/background_fetch_service_impl.cc

Issue 2762573003: Implement BackgroundFetchManager.fetch() and struct traits (Closed)
Patch Set: First round of comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/background_fetch/background_fetch_service_impl.cc
diff --git a/content/browser/background_fetch/background_fetch_service_impl.cc b/content/browser/background_fetch/background_fetch_service_impl.cc
index d9238374d0fdfe5fd81c54aa0dd9e4c3372917a6..ac93b612b2cb256b7f80c42b1fb6426296296738 100644
--- a/content/browser/background_fetch/background_fetch_service_impl.cc
+++ b/content/browser/background_fetch/background_fetch_service_impl.cc
@@ -6,8 +6,10 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
+#include "base/optional.h"
#include "content/browser/background_fetch/background_fetch_context.h"
#include "content/browser/service_worker/service_worker_context_wrapper.h"
+#include "content/common/background_fetch/background_fetch_types.h"
#include "content/public/browser/browser_thread.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
@@ -36,6 +38,25 @@ BackgroundFetchServiceImpl::BackgroundFetchServiceImpl(
BackgroundFetchServiceImpl::~BackgroundFetchServiceImpl() = default;
+void BackgroundFetchServiceImpl::Fetch(int64_t service_worker_registration_id,
+ const std::string& tag,
+ const BackgroundFetchOptions& options,
+ const FetchCallback& callback) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+
+ // TODO(peter): Create a new job with the BackgroundFetchContext for the
+ // given tag, requests and options. For now we return a registration that's
+ // based on the given |options|, to make sure round-trip is covered.
+
+ BackgroundFetchRegistration registration;
+ registration.tag = tag;
+ registration.icons = options.icons;
+ registration.title = options.title;
+ registration.total_download_size = options.total_download_size;
+
+ callback.Run(blink::mojom::BackgroundFetchError::NONE, registration);
+}
+
void BackgroundFetchServiceImpl::UpdateUI(
int64_t service_worker_registration_id,
const std::string& tag,
@@ -70,7 +91,7 @@ void BackgroundFetchServiceImpl::GetRegistration(
// and construct a BackgroundFetchRegistrationPtr for it.
callback.Run(blink::mojom::BackgroundFetchError::NONE,
- nullptr /* registration */);
+ base::nullopt /* registration */);
}
void BackgroundFetchServiceImpl::GetTags(int64_t service_worker_registration_id,

Powered by Google App Engine
This is Rietveld 408576698