Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: ppapi/proxy/plugin_globals.h

Issue 2762513002: Remove keep-alive impulse IPCs from NaCl modules. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/nacl_irt/ppapi_dispatcher.cc ('k') | ppapi/proxy/plugin_globals.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_globals.h
diff --git a/ppapi/proxy/plugin_globals.h b/ppapi/proxy/plugin_globals.h
index 2821ce7aca6a885fbf88e240fd62fb0d55cab944..09ce0d6ba236c0d3148d4ad8b473042bbfd527ae 100644
--- a/ppapi/proxy/plugin_globals.h
+++ b/ppapi/proxy/plugin_globals.h
@@ -77,7 +77,6 @@ class PPAPI_PROXY_EXPORT PluginGlobals : public PpapiGlobals {
const std::string& value) override;
MessageLoopShared* GetCurrentMessageLoop() override;
base::TaskRunner* GetFileTaskRunner() override;
- void MarkPluginIsActive() override;
// Returns the channel for sending to the browser.
IPC::Sender* GetBrowserSender();
@@ -149,20 +148,12 @@ class PPAPI_PROXY_EXPORT PluginGlobals : public PpapiGlobals {
void RegisterResourceMessageFilters(
ppapi::proxy::PluginMessageFilter* plugin_filter);
- // Interval to limit how many IPC messages are sent indicating that the plugin
- // is active and should be kept alive. The value must be smaller than any
- // threshold used to kill inactive plugins by the embedder host.
- void set_keepalive_throttle_interval_milliseconds(unsigned i);
-
private:
class BrowserSender;
// PpapiGlobals overrides.
bool IsPluginGlobals() const override;
- // Locks the proxy lock and releases the throttle on keepalive IPC messages.
- void OnReleaseKeepaliveThrottle();
-
static PluginGlobals* plugin_globals_;
PluginProxyDelegate* plugin_proxy_delegate_;
@@ -195,14 +186,6 @@ class PPAPI_PROXY_EXPORT PluginGlobals : public PpapiGlobals {
scoped_refptr<UDPSocketFilter> udp_socket_filter_;
- // Indicates activity by the plugin. Used to monitor when a plugin can be
- // shutdown due to idleness. Current needs do not require differentiating
- // between idle state between multiple instances, if any are active they are
- // all considered active.
- bool plugin_recently_active_;
-
- unsigned keepalive_throttle_interval_milliseconds_;
-
// Member variables should appear before the WeakPtrFactory, see weak_ptr.h.
base::WeakPtrFactory<PluginGlobals> weak_factory_;
« no previous file with comments | « ppapi/nacl_irt/ppapi_dispatcher.cc ('k') | ppapi/proxy/plugin_globals.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698