Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6086)

Unified Diff: chrome/browser/extensions/lazy_background_page_apitest.cc

Issue 2762513002: Remove keep-alive impulse IPCs from NaCl modules. (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/lazy_background_page_apitest.cc
diff --git a/chrome/browser/extensions/lazy_background_page_apitest.cc b/chrome/browser/extensions/lazy_background_page_apitest.cc
index 433df5d7927c7e35cdec683bf05a88aee918e739..5b0696b90b2a68dad0651a9e8a55bfe6d68e9437 100644
--- a/chrome/browser/extensions/lazy_background_page_apitest.cc
+++ b/chrome/browser/extensions/lazy_background_page_apitest.cc
@@ -510,39 +510,6 @@ IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, Messaging) {
EXPECT_FALSE(IsBackgroundPageAlive(last_loaded_extension_id()));
}
-// Tests that a KeepaliveImpulse increments the keep alive count, but eventually
-// times out and background page will still close.
-IN_PROC_BROWSER_TEST_F(LazyBackgroundPageApiTest, ImpulseAddsCount) {
- ASSERT_TRUE(StartEmbeddedTestServer());
- const Extension* extension = LoadExtensionAndWait("messaging");
- ASSERT_TRUE(extension);
-
- // Lazy Background Page doesn't exist yet.
- ProcessManager* pm = ProcessManager::Get(browser()->profile());
- EXPECT_FALSE(pm->GetBackgroundHostForExtension(last_loaded_extension_id()));
- EXPECT_EQ(1, browser()->tab_strip_model()->count());
-
- // Navigate to a page that opens a message channel to the background page.
- ResultCatcher catcher;
- LazyBackgroundObserver lazybg;
- ui_test_utils::NavigateToURL(
- browser(), embedded_test_server()->GetURL("/extensions/test_file.html"));
- lazybg.WaitUntilLoaded();
-
- // Add an impulse and the keep alive count increases.
- int previous_keep_alive_count = pm->GetLazyKeepaliveCount(extension);
- pm->KeepaliveImpulse(extension);
- EXPECT_EQ(previous_keep_alive_count + 1,
- pm->GetLazyKeepaliveCount(extension));
-
- // Navigate away, closing the message channel and therefore the background
- // page after the impulse times out.
- ui_test_utils::NavigateToURL(browser(), GURL("about:blank"));
- lazybg.WaitUntilClosed();
-
- EXPECT_FALSE(pm->GetBackgroundHostForExtension(last_loaded_extension_id()));
-}
-
// Tests that the lazy background page receives the unload event when we
// close it, and that it can execute simple API calls that don't require an
// asynchronous response.
« no previous file with comments | « chrome/browser/extensions/app_background_page_apitest.cc ('k') | chrome/browser/nacl_host/nacl_browser_delegate_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698