Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Unified Diff: extensions/browser/process_manager.h

Issue 2762513002: Remove keep-alive impulse IPCs from NaCl modules. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/process_manager.h
diff --git a/extensions/browser/process_manager.h b/extensions/browser/process_manager.h
index 439626b353c6cb4863048eecdad7e352153f7a50..8a14e7bb512f3f5ff3f6745346eb62b8132dffde 100644
--- a/extensions/browser/process_manager.h
+++ b/extensions/browser/process_manager.h
@@ -122,16 +122,6 @@ class ProcessManager : public KeyedService,
void IncrementLazyKeepaliveCount(const Extension* extension);
void DecrementLazyKeepaliveCount(const Extension* extension);
- // Keeps a background page alive. Unlike IncrementLazyKeepaliveCount, these
- // impulses will only keep the page alive for a limited amount of time unless
- // called regularly.
- void KeepaliveImpulse(const Extension* extension);
-
- // Triggers a keepalive impulse for a plugin (e.g NaCl).
- static void OnKeepaliveFromPlugin(int render_process_id,
- int render_frame_id,
- const std::string& extension_id);
-
// Handles a response to the ShouldSuspend message, used for lazy background
// pages.
void OnShouldSuspendAck(const std::string& extension_id,
@@ -154,14 +144,6 @@ class ProcessManager : public KeyedService,
// Called on shutdown to close our extension hosts.
void CloseBackgroundHosts();
- // Sets callbacks for testing keepalive impulse behavior.
- using ImpulseCallbackForTesting =
- base::Callback<void(const std::string& extension_id)>;
- void SetKeepaliveImpulseCallbackForTesting(
- const ImpulseCallbackForTesting& callback);
- void SetKeepaliveImpulseDecrementCallbackForTesting(
- const ImpulseCallbackForTesting& callback);
-
// EventPageTracker implementation.
bool IsEventPageSuspended(const std::string& extension_id) override;
bool WakeEventPage(const std::string& extension_id,
@@ -259,9 +241,6 @@ class ProcessManager : public KeyedService,
// |extension_id| known to have a lazy background page.
void DecrementLazyKeepaliveCount(const std::string& extension_id);
- // Checks if keepalive impulses have occured, and adjusts keep alive count.
- void OnKeepaliveImpulseCheck();
-
// These are called when the extension transitions between idle and active.
// They control the process of closing the background page when idle.
void OnLazyBackgroundPageIdle(const std::string& extension_id,
@@ -309,9 +288,6 @@ class ProcessManager : public KeyedService,
// True if we have created the startup set of background hosts.
bool startup_background_hosts_created_;
- ImpulseCallbackForTesting keepalive_impulse_callback_for_testing_;
- ImpulseCallbackForTesting keepalive_impulse_decrement_callback_for_testing_;
-
base::ObserverList<ProcessManagerObserver> observer_list_;
// ID Counter used to set ProcessManager::BackgroundPageData close_sequence_id

Powered by Google App Engine
This is Rietveld 408576698