Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: tests/compiler/dart2js_extra/28919_test.dart

Issue 2762493002: Type tracing bug fix for issue 28919. (Closed)
Patch Set: typo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/mock_libraries.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js_extra/28919_test.dart
diff --git a/tests/compiler/dart2js_extra/28919_test.dart b/tests/compiler/dart2js_extra/28919_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..e9b71063fc91c973728b8256e8cd37a914743792
--- /dev/null
+++ b/tests/compiler/dart2js_extra/28919_test.dart
@@ -0,0 +1,24 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// Regression test for http://dartbug.com/28919.
+//
+// This would crash at runtime because the type of closure parameter 'x' was
+// empty, leading to bad codegen. The empty type was due to a tracing bug that
+// failed to escape the closure when stored into the list which was not traced
+// as a container.
+
+import 'package:expect/expect.dart';
+
+int foo([List _methods = const []]) {
+ final methods = new List.from(_methods);
+ for (int i = 0; i < 3; i++) {
+ methods.add((int x) => x + i);
+ }
+ return methods[0](499);
+}
+
+main() {
+ Expect.equals(499, foo());
+}
« no previous file with comments | « tests/compiler/dart2js/mock_libraries.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698