Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2762493002: Type tracing bug fix for issue 28919. (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Type tracing bug fix for issue 28919. Storing a traced value into a non-traced list should escape the traced value. Also: changes to graph dumper to include all call nodes. BUG= https://github.com/dart-lang/sdk/issues/28919 R=efortuna@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ff26d99868116bcccca62d14df28700993b871bb

Patch Set 1 #

Patch Set 2 : need to test number of arguments #

Total comments: 2

Patch Set 3 : add type #

Total comments: 4

Patch Set 4 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -58 lines) Patch
M pkg/compiler/lib/src/inferrer/debug.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_engine.dart View 7 chunks +7 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 1 2 3 3 chunks +101 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_dump.dart View 4 chunks +19 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_system.dart View 2 chunks +7 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/closure_tracer_28919_test.dart View 1 chunk +91 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A tests/compiler/dart2js_extra/28919_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sra1
3 years, 9 months ago (2017-03-21 00:21:40 UTC) #3
Emily Fortuna
lgtm https://codereview.chromium.org/2762493002/diff/20001/pkg/compiler/lib/src/inferrer/node_tracer.dart File pkg/compiler/lib/src/inferrer/node_tracer.dart (right): https://codereview.chromium.org/2762493002/diff/20001/pkg/compiler/lib/src/inferrer/node_tracer.dart#newcode290 pkg/compiler/lib/src/inferrer/node_tracer.dart:290: void bailoutIfReaches(predicate) { add function type to "predicate" ...
3 years, 9 months ago (2017-03-21 00:38:59 UTC) #4
Siggi Cherem (dart-lang)
lgtm! thanks for looking into this Stephen. https://codereview.chromium.org/2762493002/diff/40001/pkg/compiler/lib/src/inferrer/node_tracer.dart File pkg/compiler/lib/src/inferrer/node_tracer.dart (right): https://codereview.chromium.org/2762493002/diff/40001/pkg/compiler/lib/src/inferrer/node_tracer.dart#newcode341 pkg/compiler/lib/src/inferrer/node_tracer.dart:341: // Not ...
3 years, 9 months ago (2017-03-21 17:05:01 UTC) #5
sra1
Committed patchset #4 (id:60001) manually as ff26d99868116bcccca62d14df28700993b871bb (presubmit successful).
3 years, 9 months ago (2017-03-21 17:55:47 UTC) #7
sra1
3 years, 9 months ago (2017-03-21 18:17:22 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2762493002/diff/20001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/2762493002/diff/20001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/node_tracer.dart:290: void
bailoutIfReaches(predicate) {
On 2017/03/21 00:38:58, Emily Fortuna wrote:
> add function type to "predicate" ? 

Done.

https://codereview.chromium.org/2762493002/diff/40001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/inferrer/node_tracer.dart (right):

https://codereview.chromium.org/2762493002/diff/40001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/node_tracer.dart:341: // Not a container or mask,
so the targets could be any methods. There
On 2017/03/21 17:05:01, Siggi Cherem (dart-lang) wrote:
> or mask => or map

Done.

https://codereview.chromium.org/2762493002/diff/40001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/inferrer/node_tracer.dart:364:
bailoutIfReaches(isParameterOfListAddingMethod);
On 2017/03/21 17:05:01, Siggi Cherem (dart-lang) wrote:
> would this case ever occur? (since the key is likely `int` and we don't trace
> ints)?

It could happen in code that would throw an exception containing the traced
'index'. Not in strong mode, through.

Powered by Google App Engine
This is Rietveld 408576698