third_party/WebKit/Source/web/InspectorOverlay.cpp - Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2762423003: Made Frame constructors (and subclasses) take Page& instead of Page* (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/InspectorOverlay.cpp

diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp

index 370cfb8228b45d76ee4066f0dbc0649d999ee9ba..79a12c8f24c1e71dced203bf6182b86483b44e53 100644

--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp

+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp

@@ -546,7 +546,7 @@ Page* InspectorOverlay::overlayPage() {

overlaySettings.setAcceleratedCompositingEnabled(false);

LocalFrame* frame =

- LocalFrame::create(&dummyLocalFrameClient, m_overlayPage, 0);

+ LocalFrame::create(&dummyLocalFrameClient, *m_overlayPage, 0);

frame->setView(FrameView::create(*frame));

frame->init();

FrameLoader& loader = frame->loader();