Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2762413002: Run dartfmt on additional generated files. (Closed)

Created:
3 years, 9 months ago by devoncarew
Modified:
3 years, 9 months ago
Reviewers:
Jacob, Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Run dartfmt on additional generated files. BUG= Committed: https://github.com/dart-lang/sdk/commit/f486a21d8f2089ba83e98758d51f0bc53d7d6c2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1806 lines, -1063 lines) Patch
M pkg/analyzer_plugin/lib/protocol/protocol_constants.dart View 3 chunks +12 lines, -6 lines 0 comments Download
M pkg/analyzer_plugin/lib/protocol/protocol_generated.dart View 253 chunks +1428 lines, -602 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart View 9 chunks +49 lines, -23 lines 0 comments Download
M pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart View 72 chunks +317 lines, -432 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
devoncarew
Run dartfmt on additional generated files; TBR.
3 years, 9 months ago (2017-03-21 23:23:17 UTC) #2
devoncarew
Committed patchset #1 (id:1) manually as f486a21d8f2089ba83e98758d51f0bc53d7d6c2f (presubmit successful).
3 years, 9 months ago (2017-03-21 23:23:51 UTC) #4
Brian Wilkerson
3 years, 9 months ago (2017-03-21 23:41:41 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698