Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h

Issue 2762403002: Wire up the ThrottleManager using the existing page activation logic (Closed)
Patch Set: engedy review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
index 3bd570b36b7e3729c9ecae2fece8c4ceaadbf9ea..e113c3cc890bbb450240095f48ca54ec2a3e9ed7 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
@@ -21,6 +21,10 @@ class NavigationThrottle;
class RenderFrameHost;
} // namespace content
+namespace IPC {
+class Message;
+} // namespace IPC
+
namespace subresource_filter {
class AsyncDocumentSubresourceFilter;
@@ -51,6 +55,10 @@ class ContentSubresourceFilterThrottleManager
// have a specific whitelist.
virtual bool ShouldSuppressActivation(
content::NavigationHandle* navigation_handle);
+
+ // Temporary method to help the delegate compute the activation decision.
+ virtual void WillProcessResponse(
+ content::NavigationHandle* navigation_handle) {}
};
ContentSubresourceFilterThrottleManager(
@@ -94,6 +102,8 @@ class ContentSubresourceFilterThrottleManager
content::NavigationHandle* navigation_handle) override;
void DidFinishNavigation(
content::NavigationHandle* navigation_handle) override;
+ bool OnMessageReceived(const IPC::Message& message,
+ content::RenderFrameHost* render_frame_host) override;
private:
std::unique_ptr<SubframeNavigationFilteringThrottle>

Powered by Google App Engine
This is Rietveld 408576698