net/cert/cert_verify_proc_nss.cc - Issue 27624002: Add a histogram for measuring the number of times we fall back to common name matching, when a cert…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_nss.cc

Issue 27624002: Add a histogram for measuring the number of times we fall back to common name matching, when a cert… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_verify_proc_nss.cc

diff --git a/net/cert/cert_verify_proc_nss.cc b/net/cert/cert_verify_proc_nss.cc

index 0a0743c150d7a5487a6758d423093bf1f21008c2..31c38c7fc1c9cef5848fb5e02db9e9ac8e6b7854 100644

--- a/net/cert/cert_verify_proc_nss.cc

+++ b/net/cert/cert_verify_proc_nss.cc

@@ -763,9 +763,10 @@ int CertVerifyProcNSS::VerifyInternal(

CERTCertificate* cert_handle = cert->os_cert_handle();

#endif // defined(OS_IOS)

- // Make sure that the hostname matches with the common name of the cert.

- if (!cert->VerifyNameMatch(hostname))

+ if (!cert->VerifyNameMatch(hostname,

+ &verify_result->common_name_fallback_used)) {

verify_result->cert_status |= CERT_STATUS_COMMON_NAME_INVALID;

+ }

// Make sure that the cert is valid now.

SECCertTimeValidity validity = CERT_CheckCertValidTimes(

« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/cert_verify_proc_openssl.cc » ('j') | no next file with comments »