net/cert/x509_certificate.cc - Issue 27624002: Add a histogram for measuring the number of times we fall back to common name matching, when a cert…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate.cc

Issue 27624002: Add a histogram for measuring the number of times we fall back to common name matching, when a cert… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/x509_certificate.cc

diff --git a/net/cert/x509_certificate.cc b/net/cert/x509_certificate.cc

index 36e806ebaba7ba14a0ef30bba9a764b73a798abc..5853de938fcb950aa8d0e8ca5f63f49b89556a08 100644

--- a/net/cert/x509_certificate.cc

+++ b/net/cert/x509_certificate.cc

@@ -528,6 +528,7 @@ bool X509Certificate::VerifyHostname(

// Allow fallback to Common name matching?

const bool common_name_fallback = cert_san_dns_names.empty() &&

cert_san_ip_addrs.empty();

+ UMA_HISTOGRAM_BOOLEAN("Net.CertCommonNameFallback", common_name_fallback);

// Fully handle all cases where |hostname| contains an IP address.

if (host_info.IsIPAddress()) {

« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')